Commit 243ffee

asadbek2021hjr3

authored and

committed

fix: wait for pool.end()

Because when you don't pass a callback to .end() it always returns a promise

1 parent 0188277 commit 243ffeeCopy full SHA for 243ffee

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -365,16 +365,15 @@ class Pool extends EventEmitter {`
`365`	`365`	`if (isExpired) {`
`366`	`366`	`this.log('remove expired client')`
`367`	`367`	`this._expired.delete(client)`
`368`		`- this._remove(client, this._pulseQueue.bind(this))`
`369`		`- return`
	`368`	`+ return this._remove(client, this._pulseQueue.bind(this))`
`370`	`369`	`}`
`371`	`370`
`372`	`371`	`// idle timeout`
`373`	`372`	`let tid`
`374`	`373`	`if (this.options.idleTimeoutMillis && this._isAboveMin()) {`
`375`	`374`	`tid = setTimeout(() => {`
`376`	`375`	`this.log('remove idle client')`
`377`		`- this._remove(client)`
	`376`	`+ this._remove(client,this._pulseQueue.bind(this))`
`378`	`377`	`}, this.options.idleTimeoutMillis)`
`379`	`378`
`380`	`379`	`if (this.options.allowExitOnIdle) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ describe('idle timeout', () => {`
`50`	`50`	`try {`
`51`	`51`	`yield Promise.race([removal, timeout])`
`52`	`52`	`} finally {`
`53`		`- pool.end()`
	`53`	`+ yieldpool.end()`
`54`	`54`	`}`
`55`	`55`	`})`
`56`	`56`	`)`

Comments

(0)