Commit 14dc8dd

authored

Use performance.now() instead of Date.now()... (#3483)

* Use performance.now() instead of Date.now()... * Wherever applicable (measuring performance, not time). * Failback to support node < 16.0.0 (perf_hook not globally exposed) * Failback to Date.now() for node < 8.5.0 ✔ Tests passed with node > 16.0.0 (22.12.0) ✕ Couldn't pass with node prior 16.0.0 but not due to this changes. https://nodejs.org/docs/latest-v8.x/api/perf_hooks.html#perf_hooks_performance_now https://w3c.github.io/hr-time/ * Yarn prettier * More lint fixes. * Removed polyfill code for node <16 They are no longer supported: #3483 (comment)

1 parent 8608fb8 commit 14dc8ddCopy full SHA for 14dc8dd

File tree

3 files changed

-8

lines changed

packages
- pg-native/bench
  - leaks.js
- pg-protocol/src
  - b.ts
- pg
  - bench.js

3 files changed

-8

lines changed

`‎packages/pg-native/bench/leaks.js`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ const loop = function () {`
`37`	`37`
`38`	`38`	`const ops = [connect, simpleQuery, paramsQuery, prepared, sync, end]`
`39`	`39`
`40`		`- const start = Date.now()`
	`40`	`+ const start = performance.now()`
`41`	`41`	`async.series(ops, function (err) {`
`42`	`42`	`if (err) throw err`
`43`		`- console.log(Date.now() - start)`
	`43`	`+ console.log(performance.now() - start)`
`44`	`44`	`setImmediate(loop)`
`45`	`45`	`})`
`46`	`46`	`}`

`‎packages/pg-protocol/src/b.ts`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,14 +4,14 @@ import { BufferReader } from './buffer-reader'`
`4`	`4`
`5`	`5`	`const LOOPS = 1000`
`6`	`6`	`let count = 0`
`7`		`-const start = Date.now()`
	`7`	`+const start = performance.now()`
`8`	`8`
`9`	`9`	`const reader = new BufferReader()`
`10`	`10`	`const buffer = Buffer.from([33, 33, 33, 33, 33, 33, 33, 0])`
`11`	`11`
`12`	`12`	`const run = () => {`
`13`	`13`	`if (count > LOOPS) {`
`14`		`- console.log(Date.now() - start)`
	`14`	`+ console.log(performance.now() - start)`
`15`	`15`	`return`
`16`	`16`	`}`
`17`	`17`	`count++`

`‎packages/pg/bench.js`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,13 +23,13 @@ const exec = async (client, q) => {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`const bench = async (client, q, time) => {`
`26`		`- const start = Date.now()`
	`26`	`+ const start = performance.now()`
`27`	`27`	`let count = 0`
`28`	`28`	`// eslint-disable-next-line no-constant-condition`
`29`	`29`	`while (true) {`
`30`	`30`	`await exec(client, q)`
`31`	`31`	`count++`
`32`		`- if (Date.now() - start > time) {`
	`32`	`+ if (performance.now() - start > time) {`
`33`	`33`	`return count`
`34`	`34`	`}`
`35`	`35`	`}`
`@@ -77,9 +77,9 @@ const run = async () => {`
`77`	`77`	`values: ['test', Buffer.allocUnsafe(104857600)],`
`78`	`78`	`})`
`79`	`79`	`console.log('bytea warmup done')`
`80`		`- const start = Date.now()`
	`80`	`+ const start = performance.now()`
`81`	`81`	`const results = await client.query('SELECT * FROM buf')`
`82`		`- const time = Date.now() - start`
	`82`	`+ const time = performance.now() - start`
`83`	`83`	`console.log('bytea time:', time, 'ms')`
`84`	`84`	`console.log('bytea length:', results.rows[0].data.byteLength, 'bytes')`
`85`	`85`	`console.log('on my laptop best so far seen 1407ms and 104857600 bytes')`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 14dc8dd

File tree

3 files changed

3 files changed

`‎packages/pg-native/bench/leaks.js`

`‎packages/pg-protocol/src/b.ts`

`‎packages/pg/bench.js`

0 commit comments