Commit 009acb9

committed

Add test for pool.end method

1 parent 33e0f16 commit 009acb9Copy full SHA for 009acb9

File tree

+13

-3

lines changed

+13

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -167,10 +167,10 @@ class Pool extends EventEmitter {`
`167`	`167`	`client.end(() => {`
`168`	`168`	`this.emit('remove', client)`
`169`	`169`
`170`		`- if (typeof callback === "function") {`
	`170`	`+ if (typeof callback === 'function') {`
`171`	`171`	`callback()`
`172`	`172`	`}`
`173`		`- })`
	`173`	`+ })`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`connect(cb) {`
`@@ -348,7 +348,7 @@ class Pool extends EventEmitter {`
`348`	`348`	`this.log('remove expended client')`
`349`	`349`	`}`
`350`	`350`
`351`		`- return this._remove(client, this._pulseQueue.bind(this))`
	`351`	`+ return this._remove(client, this._pulseQueue.bind(this))`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`const isExpired = this._expired.has(client)`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,4 +37,14 @@ describe('pool ending', () => {`
`37`	`37`	`expect(res.rows[0].name).to.equal('brianc')`
`38`	`38`	`})`
`39`	`39`	`)`
	`40`	`+`
	`41`	`+ it('pool.end() - finish pending queries', async () => {`
	`42`	`+ const pool = new Pool({ max: 20 })`
	`43`	`+ let completed = 0`
	`44`	`+ for (let x = 1; x <= 20; x++) {`
	`45`	`+ pool.query('SELECT 1ドル::text as name', ['brianc']).then(() => completed++)`
	`46`	`+ }`
	`47`	`+ await pool.end()`
	`48`	`+ expect(completed).to.equal(20)`
	`49`	`+ })`
`40`	`50`	`})`

Comments

(0)