Commit 8a078ff

committed

remove TODOs for finished things

1 parent 94b8363 commit 8a078ffCopy full SHA for 8a078ff

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,6 @@ func HandleDeath(r room.Room, loser player.Player, winner *player.Player) {`
`307`	`307`	`return`
`308`	`308`	`}`
`309`	`309`
`310`		`- // TODO: loser is kicked instead of shown the result screen`
`311`	`310`	`conn.Send(AnyMessage {`
`312`	`311`	`Op: OpClose,`
`313`	`312`	`T: PlayerKickEvent,`
`@@ -339,8 +338,6 @@ func HandleEnd(r *room.Room) {`
`339`	`338`	`return`
`340`	`339`	`}`
`341`	`340`
`342`		`- // TODO: winner is kicked without a reason`
`343`		`- // instead, don't use OpClose and send it as event instead`
`344`	`341`	`conn.Send(AnyMessage{`
`345`	`342`	`Op: OpClose,`
`346`	`343`	`T: PlayerKickEvent,`
`@@ -354,7 +351,5 @@ func HandleEnd(r *room.Room) {`
`354`	`351`
`355`	`352`	`handleClose(conn)`
`356`	`353`
`357`		`- // TODO: delete room and create new room`
`358`		`- // or alternatively, create a reset function on room struct`
`359`		`- // that sets the state to waiting and other prep stuff`
	`354`	`+ r.Reset()`
`360`	`355`	`}`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,6 @@ func NomKeyEventCallback(c WebSocketConnection, d AnyMessage) {`
`53`	`53`
`54`	`54`	`if r.Mode == room.EliminationMode {`
`55`	`55`	`HandleDeath(r, target, p)`
`56`		`- // TODO: kick target and update br, coins, xp, etc`
`57`	`56`	`break`
`58`	`57`	`} else {`
`59`	`58`	`target.Health = 100`

Comments

(0)