Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

GuzzleHttp client with custom options #1110

maxcelos started this conversation in Ideas
Discussion options

Looks like the config broadcasting.connections.pusher.client_options is not taking any effect. I guess it should be used to instantiate a GuzzleHttp client with custom options and pass it to Pusher.

This change should do:

// src/Dashboard/Http/Controllers/SendMessage.php
protected function getPusherBroadcaster(array $validated): PusherBroadcaster
{
+ $client = new \GuzzleHttp\Client(config('broadcasting.connections.pusher.client_options', []));
+
 $pusher = new Pusher(
 $validated['key'],
 $validated['secret'],
 $validated['appId'],
 config('broadcasting.connections.pusher.options', []),
+ $client 
 );
 return new PusherBroadcaster($pusher);
}
You must be logged in to vote

Replies: 1 comment

Comment options

Make a PR

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Ideas
Labels
None yet

AltStyle によって変換されたページ (->オリジナル) /