Commit 9f94f89

committed

feat(shellcheck): add code actions to disable rule

Implements #933. Always add a code action to disable a given diagnostic for a given line or for the whole file. This patch handles: * indentation * existing directive. It also sorts the disable directives if any * multi-line command Add corresponding tests. Signed-off-by: Thomas Faivre <thfaivre@gmail.com>

1 parent aec18c7 commit 9f94f89Copy full SHA for 9f94f89

File tree

4 files changed

+2274

-69

lines changed

server/src
- __tests__
  - server.test.ts
- server.ts
- shellcheck
  - __tests__
    - index.test.ts
  - index.ts

4 files changed

+2274

-69

lines changed

`‎server/src/tests/server.test.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ describe('server', () => {`
`216`	`216`	`{} as any,`
`217`	`217`	`)`
`218`	`218`
`219`		`- expect(result).toHaveLength(1)`
	`219`	`+ expect(result).toHaveLength(3)`
`220`	`220`	`const codeAction = (result as CodeAction[])[0]`
`221`	`221`	`expect(codeAction.diagnostics).toEqual([fixableDiagnostic])`
`222`	`222`	`expect(codeAction.diagnostics).toEqual([fixableDiagnostic])`

`‎server/src/server.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ export default class BashServer {`
`398`	`398`
`399`	`399`	`const codeActions = params.context.diagnostics`
`400`	`400`	`.map(({ data }) => codeActionsForUri[data?.id])`
`401`		`- .filter((action): action is LSP.CodeAction=>action!=null)`
	`401`	`+ .flat()`
`402`	`402`
`403`	`403`	logger.debug(`onCodeAction: found ${codeActions.length} code action(s)`)
`404`	`404`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 9f94f89

File tree

4 files changed

4 files changed

`‎server/src/tests/server.test.ts‎`

`‎server/src/server.ts‎`

0 commit comments

File tree

4 files changed

4 files changed

‎server/src/__tests__/server.test.ts‎

‎server/src/server.ts‎

0 commit comments

`‎server/src/tests/server.test.ts‎`

`‎server/src/server.ts‎`