Commit 6063977

KonTraxmads-hartmann

authored and

committed

More reliable npm command execution on windows (#40)

More reliable npm command execution on windows Append '.cmd' extension when spawning child process for npm command on windows as '.cmd'/'.bat' files are not included when searching for executable by basename.

1 parent 955d35c commit 6063977Copy full SHA for 6063977

File tree

1 file changed

-1

lines changed

vscode-client/src
- util.ts

1 file changed

-1

lines changed

`‎vscode-client/src/util.ts‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,8 @@ function isWindows() {`
`7`	`7`
`8`	`8`	`function getBasePath(): Promise<string> {`
`9`	`9`	`return new Promise((resolve, reject) => {`
`10`		`- execFile('npm', ['bin', '-g'], (err, stdout) => {`
	`10`	`+ const npmBin = isWindows() ? 'npm.cmd' : 'npm'`
	`11`	`+ execFile(npmBin, ['bin', '-g'], (err, stdout) => {`
`11`	`12`	`if (err) {`
`12`	`13`	`reject(err)`
`13`	`14`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 6063977

File tree

1 file changed

1 file changed

`‎vscode-client/src/util.ts‎`

0 commit comments