Commit 00d79a5

committed

Show hover information for builtins

1 parent a5e6a94 commit 00d79a5Copy full SHA for 00d79a5

File tree

+21

-8

lines changed

+21

-8

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,10 @@ export const LIST = [`
`62`	`62`	`'wait',`
`63`	`63`	`]`
`64`	`64`
	`65`	`+export function isBuiltin(word: string): boolean {`
	`66`	`+ return LIST.find(builtin => builtin === word) !== undefined`
	`67`	`+}`
	`68`	`+`
`65`	`69`	`export async function documentation(builtin: string): Promise<string> {`
`66`	`70`	const errorMessage = `No help page for ${builtin}`
`67`	`71`	`try {`

Lines changed: 17 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -107,14 +107,23 @@ export default class BashServer {`
`107`	`107`
`108`	`108`	`const word = this.getWordAtPoint(pos)`
`109`	`109`
`110`		`- return this.executables.isExecutableOnPATH(word)`
`111`		`- ? this.executables.documentation(word).then(doc => ({`
`112`		`- contents: {`
`113`		`- language: 'plaintext',`
`114`		`- value: doc,`
`115`		`- },`
`116`		`- }))`
`117`		`- : null`
	`110`	`+ if (Builtins.isBuiltin(word)) {`
	`111`	`+ return Builtins.documentation(word).then(doc => ({`
	`112`	`+ contents: {`
	`113`	`+ language: 'plaintext',`
	`114`	`+ value: doc,`
	`115`	`+ },`
	`116`	`+ }))`
	`117`	`+ } else if (this.executables.isExecutableOnPATH(word)) {`
	`118`	`+ return this.executables.documentation(word).then(doc => ({`
	`119`	`+ contents: {`
	`120`	`+ language: 'plaintext',`
	`121`	`+ value: doc,`
	`122`	`+ },`
	`123`	`+ }))`
	`124`	`+ } else {`
	`125`	`+ return null`
	`126`	`+ }`
`118`	`127`	`}`
`119`	`128`
`120`	`129`	`private onDefinition(pos: LSP.TextDocumentPositionParams): LSP.Definition {`

Comments

(0)