Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 9d75033

Browse files
move signalr client service configuration/startup to mounted lifecycle event on the Vue instance rather than Login.vue component; bump .NET Core nuget packages to latest versions
1 parent a693cb6 commit 9d75033

File tree

6 files changed

+30
-21
lines changed

6 files changed

+30
-21
lines changed

‎GhostUI/ClientApp/package-lock.json‎

Lines changed: 21 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎GhostUI/ClientApp/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"@vue/test-utils": "1.1.0",
4545
"eslint": "^7.10.0",
4646
"eslint-plugin-prettier": "^3.1.4",
47-
"eslint-plugin-vue": "^6.2.2",
47+
"eslint-plugin-vue": "^7.0.0",
4848
"node-sass": "^4.14.1",
4949
"prettier": "^2.1.2",
5050
"sass-loader": "^10.0.2",

‎GhostUI/ClientApp/src/main.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import store from '@/store';
66
import router from '@/router';
77
import Snotify from 'vue-snotify';
88
import { vClickOutside } from '@/plugins';
9+
import { SignalRApi } from '@/api/signalR.service';
910
import { snotifyDefaults } from '@/config/vue-snotify.config';
1011
import AxiosGlobalConfig from '@/config/axios.config';
1112
import '@/config/fa.config';
@@ -17,8 +18,12 @@ AxiosGlobalConfig.setup();
1718
Vue.use(vClickOutside)
1819
.use(Snotify, snotifyDefaults);
1920

21+
// In the mounted callback configure Signalr - wrap in this.$nextTick callback to ensure all children mount as well
2022
new Vue({
2123
router,
2224
store,
2325
render: (h) => h(App),
26+
mounted() {
27+
this.$nextTick(() => SignalRApi.startConnection());
28+
}
2429
}).$mount('#app');

‎GhostUI/ClientApp/src/views/Login/Login.vue‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131

3232
<script lang="ts">
3333
import { Component, Vue } from "vue-property-decorator";
34-
import { SignalRApi } from "../../api";
3534
import { Authenticator } from "../../components";
3635
import { AuthModule, AuthStatusEnum } from "../../store/modules/auth";
3736
import { UserNameInput, PasswordInput, RememberMeInput } from "./child-components";
@@ -52,10 +51,6 @@ export default class Login extends Vue {
5251
return AuthModule.isLoginInputValid;
5352
}
5453
55-
public mounted(): void {
56-
SignalRApi.startConnection();
57-
}
58-
5954
public handleLogin(): void {
6055
if (this.authStatus === AuthStatusEnum.PROCESS) {
6156
return;

‎GhostUI/GhostUI.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
<PackageReference Include="AspNetCore.HealthChecks.UI" Version="3.1.3" />
2222
<PackageReference Include="AspNetCore.HealthChecks.UI.Client" Version="3.1.2" />
2323
<PackageReference Include="AspNetCore.HealthChecks.UI.InMemory.Storage" Version="3.1.2" />
24-
<PackageReference Include="NSwag.AspNetCore" Version="13.8.1" />
25-
<PackageReference Include="NSwag.MSBuild" Version="13.8.1">
24+
<PackageReference Include="NSwag.AspNetCore" Version="13.8.2" />
25+
<PackageReference Include="NSwag.MSBuild" Version="13.8.2">
2626
<PrivateAssets>all</PrivateAssets>
2727
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
2828
</PackageReference>

‎GhostUI/wwwroot/docs/api-specification.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"x-generator": "NSwag v13.8.1.0 (NJsonSchema v10.2.0.0 (Newtonsoft.Json v12.0.0.0))",
2+
"x-generator": "NSwag v13.8.2.0 (NJsonSchema v10.2.1.0 (Newtonsoft.Json v12.0.0.0))",
33
"openapi": "3.0.0",
44
"info": {
55
"title": "GhostUI API",

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /