Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 25cbf5a

Browse files
refactoring Vue.js ClientApp code
1 parent d241e97 commit 25cbf5a

File tree

17 files changed

+116
-132
lines changed

17 files changed

+116
-132
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
> 1%
2-
last2versions
3-
not ie<=8
1+
> 0.2%
2+
notdead
3+
not op_miniall

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/package-lock.json

Lines changed: 27 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@
1111
},
1212
"dependencies": {
1313
"axios": "^0.20.0",
14-
"bulma": "^0.9.0",
14+
"bulma": "^0.9.1",
1515
"register-service-worker": "^1.7.1",
1616
"vue": "^2.6.12",
17-
"vue-class-component": "^7.2.5",
17+
"vue-class-component": "^7.2.6",
1818
"vue-js-modal": "^1.3.35",
1919
"vue-property-decorator": "^9.0.0",
20-
"vue-router": "^3.4.3",
20+
"vue-router": "^3.4.5",
2121
"vue-snotify": "^3.2.1",
2222
"vuex": "^3.5.1"
2323
},
2424
"devDependencies": {
2525
"@testing-library/jest-dom": "^5.11.4",
26-
"@types/jest": "^26.0.13",
26+
"@types/jest": "^26.0.14",
2727
"@vue/cli-plugin-babel": "^4.5.6",
2828
"@vue/cli-plugin-e2e-nightwatch": "^4.5.6",
2929
"@vue/cli-plugin-pwa": "^4.5.6",
@@ -33,9 +33,9 @@
3333
"@vue/test-utils": "1.1.0",
3434
"node-sass": "^4.14.1",
3535
"sass-loader": "^10.0.2",
36-
"ts-jest": "^26.3.0",
37-
"typescript": "^4.0.2",
36+
"ts-jest": "^26.4.1",
37+
"typescript": "^4.0.3",
3838
"vue-template-compiler": "^2.6.12",
39-
"vuex-module-decorators": "^0.17.0"
39+
"vuex-module-decorators": "^1.0.1"
4040
}
4141
}

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/components/AddEmployee.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,12 @@
8080

8181
<script lang="ts">
8282
import { Component, Prop, Vue } from "vue-property-decorator";
83-
import { alertAxiosSuccess } from "@/utils";
84-
import { IDropdownOption, IEmployee } from "@/types";
85-
import VCheckbox from "@/components/VCheckbox.render";
86-
import VDropdown from "@/components/VDropdown.render";
87-
import { dropdownTestData, modalIDs } from "@/config/constants";
88-
import { EmployeeModule } from "@/store/modules/employee.module";
83+
import { alertAxiosSuccess } from "../utils";
84+
import { IDropdownOption, IEmployee } from "../types";
85+
import VCheckbox from "./VCheckbox.render";
86+
import VDropdown from "./VDropdown.render";
87+
import { dropdownTestData, modalIDs } from "../config/constants";
88+
import { EmployeeModule } from "../store/modules/employee.module";
8989
9090
@Component({
9191
components: {

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/components/HomeContent.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,12 @@
2626

2727
<script lang="ts">
2828
import { Component, Prop, Vue } from 'vue-property-decorator';
29-
import { npmLinksConfig } from '@/config/constants';
29+
import { npmLinksConfig } from '../config/constants';
3030
3131
@Component
3232
export default class HomeContent extends Vue {
3333
@Prop() public readonly mainSubTitle: string;
34+
3435
public readonly npmLinks: Record<string, string> = npmLinksConfig;
3536
}
3637
</script>
Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,19 @@
11
<template>
22
<nav id="nav" role="navigation" aria-label="main navigation">
3-
<router-link :to="routesConfig.home.path" :id="routesConfig.home.meta.id">
4-
{{routesConfig.home.name}}
5-
</router-link>
6-
<span>|</span>
7-
<router-link :to="routesConfig.employee.path" :id="routesConfig.employee.meta.id">
8-
{{routesConfig.employee.name}}
3+
<router-link
4+
v-for="route in $router.options.routes"
5+
:key="route.path"
6+
:to="route.path"
7+
:id="route.meta.id"
8+
>
9+
{{route.name}}
910
</router-link>
1011
</nav>
1112
</template>
1213

1314
<script lang="ts">
1415
import { Component, Vue } from "vue-property-decorator";
15-
import { RoutesConfig } from "@/config/routes.config";
16-
import { RouteConfig } from "vue-router";
1716
1817
@Component
19-
export default class NavBar extends Vue {
20-
public readonly routesConfig: Record<string, RouteConfig> = RoutesConfig;
21-
}
18+
export default class NavBar extends Vue {}
2219
</script>

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/components/VCheckbox.render.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ import { Component, Prop } from "vue-property-decorator";
66
*/
77
@Component
88
export default class VCheckBox extends Vue {
9-
@Prop({ default: null }) public readonly wrapperClass: string;
10-
@Prop({ default: null }) public readonly controlClass: string;
11-
@Prop({ default: null }) public readonly trailingLabel: string;
12-
@Prop({ default: false }) public readonly checked: boolean;
13-
@Prop({ default: false }) public readonly disabled: boolean;
9+
@Prop({ default: null }) public readonly wrapperClass: string;
10+
@Prop({ default: null }) public readonly controlClass: string;
11+
@Prop({ default: null }) public readonly trailingLabel: string;
12+
@Prop({ default: false }) public readonly checked: boolean;
13+
@Prop({ default: false }) public readonly disabled: boolean;
1414

1515
public render(): VNode {
1616
return (

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/config/routes.config.ts

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/config/vue-snotify.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { SnotifyPosition, SnotifyDefaults } from "vue-snotify";
22

3-
export const snotifyDefaults=Object.freeze<SnotifyDefaults>({
3+
export const snotifyDefaults: SnotifyDefaults={
44
global: {
55
newOnTop: true,
66
maxAtPosition: 4,
@@ -15,4 +15,4 @@ export const snotifyDefaults = Object.freeze<SnotifyDefaults>({
1515
closeOnClick: true,
1616
pauseOnHover: true
1717
}
18-
});
18+
};

‎FullStackTesting/FullStackTesting.Web.Api/ClientApp/src/main.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import Snotify from 'vue-snotify';
99
import vClickOutside from '@/plugins/vue-click-outside';
1010
import { snotifyDefaults } from '@/config/vue-snotify.config';
1111

12-
Vue.use(VModal);
13-
Vue.use(vClickOutside);
14-
Vue.use(Snotify, snotifyDefaults);
15-
1612
Vue.config.productionTip = false;
1713

14+
Vue.use(VModal)
15+
.use(vClickOutside)
16+
.use(Snotify, snotifyDefaults);
17+
1818
new Vue({
1919
router,
2020
store,

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /