Commit 5f73cf7

authored

test: Use yaml.safe_load() instead of yaml.load() in cloudformation export tests

PyYAML deprecated use of yaml.load() function without Loader argument since 5.1. Updating to call safe_load() instead as load() was deemed unsafe per PyYAML documatation since its first release in 2006

1 parent 7f223e8 commit 5f73cf7Copy full SHA for 5f73cf7

File tree

1 file changed

-2

lines changed

tests/unit
- test_workflow.py

1 file changed

-2

lines changed

`‎tests/unit/test_workflow.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ def test_list_workflows(client):`
`272`	`272`
`273`	`273`	`def test_cloudformation_export_with_simple_definition(workflow):`
`274`	`274`	`cfn_template = workflow.get_cloudformation_template()`
`275`		`- cfn_template = yaml.load(cfn_template)`
	`275`	`+ cfn_template = yaml.safe_load(cfn_template)`
`276`	`276`	`assert 'StateMachineComponent' in cfn_template['Resources']`
`277`	`277`	`assert workflow.role == cfn_template['Resources']['StateMachineComponent']['Properties']['RoleArn']`
`278`	`278`	`assert cfn_template['Description'] == "CloudFormation template for AWS Step Functions - State Machine"`
`@@ -300,7 +300,7 @@ def test_cloudformation_export_with_sagemaker_execution_role(workflow):`
`300`	`300`	`}`
`301`	`301`	`})`
`302`	`302`	`cfn_template = workflow.get_cloudformation_template(description="CloudFormation template with Sagemaker role")`
`303`		`- cfn_template = yaml.load(cfn_template)`
	`303`	`+ cfn_template = yaml.safe_load(cfn_template)`
`304`	`304`	`assert json.dumps(workflow.definition.to_dict(), indent=2) == cfn_template['Resources']['StateMachineComponent']['Properties']['DefinitionString']`
`305`	`305`	`assert workflow.role == cfn_template['Resources']['StateMachineComponent']['Properties']['RoleArn']`
`306`	`306`	`assert cfn_template['Description'] == "CloudFormation template with Sagemaker role"`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 5f73cf7

File tree

1 file changed

1 file changed

`‎tests/unit/test_workflow.py`

0 commit comments