Commit 260b78d

committed

Renamed unit test and removed unnecessary comments

1 parent 8dd38ec commit 260b78dCopy full SHA for 260b78d

File tree

2 files changed

-9

lines changed

tests
- integ
  - test_sagemaker_steps.py
- unit
  - test_sagemaker_steps.py

2 files changed

-9

lines changed

`‎tests/integ/test_sagemaker_steps.py`

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,6 @@ def test_training_step(pca_estimator_fixture, record_set_fixture, sfn_client, sf`
`104`	`104`
`105`	`105`	`# Cleanup`
`106`	`106`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`107`		`- # End of Cleanup`
`108`	`107`
`109`	`108`
`110`	`109`	`def test_training_step_with_placeholders(pca_estimator_fixture, record_set_fixture, sfn_client, sfn_role_arn):`
`@@ -193,7 +192,7 @@ def test_model_step(trained_estimator, sfn_client, sagemaker_session, sfn_role_a`
`193`	`192`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`194`	`193`	`model_name = get_resource_name_from_arn(execution_output.get("ModelArn")).split("/")[1]`
`195`	`194`	`delete_sagemaker_model(model_name, sagemaker_session)`
`196`		`-# End of Cleanup`
	`195`	`+`
`197`	`196`
`198`	`197`	`def test_transform_step(trained_estimator, sfn_client, sfn_role_arn):`
`199`	`198`	`# Create transformer from previously created estimator`
`@@ -235,7 +234,6 @@ def test_transform_step(trained_estimator, sfn_client, sfn_role_arn):`
`235`	`234`
`236`	`235`	`# Cleanup`
`237`	`236`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`238`		`- # End of Cleanup`
`239`	`237`
`240`	`238`
`241`	`239`	`def test_transform_step_with_placeholder(trained_estimator, sfn_client, sfn_role_arn):`
`@@ -360,7 +358,7 @@ def test_endpoint_config_step(trained_estimator, sfn_client, sagemaker_session,`
`360`	`358`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`361`	`359`	`delete_sagemaker_endpoint_config(endpoint_config_name, sagemaker_session)`
`362`	`360`	`delete_sagemaker_model(model.name, sagemaker_session)`
`363`		`-# End of Cleanup`
	`361`	`+`
`364`	`362`
`365`	`363`	`def test_create_endpoint_step(trained_estimator, record_set_fixture, sfn_client, sagemaker_session, sfn_role_arn):`
`366`	`364`	`# Setup: Create model and endpoint config for trained estimator in SageMaker`
`@@ -403,7 +401,6 @@ def test_create_endpoint_step(trained_estimator, record_set_fixture, sfn_client,`
`403`	`401`	`delete_sagemaker_endpoint(endpoint_name, sagemaker_session)`
`404`	`402`	`delete_sagemaker_endpoint_config(model.name, sagemaker_session)`
`405`	`403`	`delete_sagemaker_model(model.name, sagemaker_session)`
`406`		`- # End of Cleanup`
`407`	`404`
`408`	`405`
`409`	`406`	`def test_tuning_step(sfn_client, record_set_for_hyperparameter_tuning, sagemaker_role_arn, sfn_role_arn):`
`@@ -455,7 +452,6 @@ def test_tuning_step(sfn_client, record_set_for_hyperparameter_tuning, sagemaker`
`455`	`452`
`456`	`453`	`# Cleanup`
`457`	`454`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`458`		`- # End of Cleanup`
`459`	`455`
`460`	`456`
`461`	`457`	`def test_tuning_step_with_placeholders(sfn_client, record_set_for_hyperparameter_tuning, sagemaker_role_arn, sfn_role_arn):`
`@@ -546,7 +542,6 @@ def test_tuning_step_with_placeholders(sfn_client, record_set_for_hyperparameter`
`546`	`542`
`547`	`543`	`# Cleanup`
`548`	`544`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`549`		`- # End of Cleanup`
`550`	`545`
`551`	`546`
`552`	`547`	`def test_processing_step(sklearn_processor_fixture, sagemaker_session, sfn_client, sfn_role_arn):`
`@@ -601,7 +596,6 @@ def test_processing_step(sklearn_processor_fixture, sagemaker_session, sfn_clien`
`601`	`596`
`602`	`597`	`# Cleanup`
`603`	`598`	`state_machine_delete_wait(sfn_client, workflow.state_machine_arn)`
`604`		`- # End of Cleanup`
`605`	`599`
`606`	`600`
`607`	`601`	`def test_processing_step_with_placeholders(sklearn_processor_fixture, sagemaker_session, sfn_client, sfn_role_arn,`

`‎tests/unit/test_sagemaker_steps.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1449,7 +1449,7 @@ def test_processing_step_creation_with_placeholders(sklearn_processor):`
`1449`	`1449`
`1450`	`1450`	`@patch('botocore.client.BaseClient._make_api_call', new=mock_boto_api_call)`
`1451`	`1451`	`@patch.object(boto3.session.Session, 'region_name', 'us-east-1')`
`1452`		`-def test_tuning_step_creation_with_framework(tensorflow_estimator):`
	`1452`	`+def test_tuning_step_creation_with_framework_estimator(tensorflow_estimator):`
`1453`	`1453`	`hyperparameter_ranges = {`
`1454`	`1454`	`"extra_center_factor": IntegerParameter(4, 10),`
`1455`	`1455`	`"epochs": IntegerParameter(1, 2),`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 260b78d

File tree

2 files changed

2 files changed

`‎tests/integ/test_sagemaker_steps.py`

`‎tests/unit/test_sagemaker_steps.py`

0 commit comments