Commit 8d4ed1a

authored

Merge pull request #2 from astral-data/fix/Parameter-order-to-comply

Fix: Parameter order to comply with PHP 8+ requirements

2 parents 6b285bd + 3a6cb0a commit 8d4ed1aCopy full SHA for 8d4ed1a

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ classInstance: $object,`
`51`	`51`	`continue;`
`52`	`52`	`}`
`53`	`53`
`54`		`- $chooseContext->addProperty(new ChoosePropertyContext($name, $chooseContext, $collection));`
	`54`	`+ $chooseContext->addProperty(new ChoosePropertyContext($name, $collection, $chooseContext));`
`55`	`55`	`$chooseContext->getProperty($name)?->setInputName($matchInput['name']);`
`56`	`56`
`57`	`57`	`$resolvedValue = $matchInput['value'];`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ classInstance: $object,`
`42`	`42`	`continue;`
`43`	`43`	`}`
`44`	`44`
`45`		`- $chooseContext->addProperty(new ChoosePropertyContext($name, $chooseContext, $collection));`
	`45`	`+ $chooseContext->addProperty(new ChoosePropertyContext($name, $collection, $chooseContext));`
`46`	`46`	`$chooseContext->getProperty($name)?->setOutPutNames($matchData['names']);`
`47`	`47`	`$resolvedValue = $matchData['value'];`
`48`	`48`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static function setGroups(array\|string $groups): SerializeContext`
`29`	`29`
`30`	`30`	`public function withGroups(array\|string $groups): static`
`31`	`31`	`{`
`32`		`- $this->getContext()->setGroups((array)$groups);`
	`32`	`+ $this->getContext()?->setGroups((array)$groups);`
`33`	`33`	`return $this;`
`34`	`34`	`}`
`35`	`35`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,15 @@ class ChoosePropertyContext`
`16`	`16`
`17`	`17`	`public function __construct(`
`18`	`18`	`private readonly string $name,`
`19`		`- private readonly ?ChooseSerializeContext $parent = null,`
`20`	`19`	`private readonly DataCollection $dataCollection,`
	`20`	`+ private readonly ?ChooseSerializeContext $parent = null,`
`21`	`21`	`) {`
`22`	`22`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`public static function build(DataCollection $collection, ChooseSerializeContext $context,DataCollection $dataCollection): ChoosePropertyContext`
`26`	`26`	`{`
`27`		`- return new self($collection->getName(), $context, $dataCollection);`
	`27`	`+ return new self($collection->getName(), $dataCollection, $context);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public function getDataCollection() : DataCollection`

Comments

(0)