Commit 554f53e

authored

Integer Overflow in Max Heap Comparator for K Closest Points to Origin

The current implementation can potentially cause overflow when the distances are large. issue solve Id: #21

1 parent 3f41a4a commit 554f53eCopy full SHA for 554f53e

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,9 @@ private int getDistance(int[] point) {`
`126`	`126`
`127`	`127`	`public int[][] kClosestPointsToOriginMaxHeapApproach(int[][] points, int k) {`
`128`	`128`	`// Max heap with custom comparator to compare by distance`
`129`		`- PriorityQueue<int[]> maxHeap = new PriorityQueue<>((a, b) -> getDistance(b) - getDistance(a));`
	`129`	`+ PriorityQueue<int[]> maxHeap = new PriorityQueue<>(`
	`130`	`+ (a, b) -> Integer.compare(getDistance(b), getDistance(a))`
	`131`	`+ );`
`130`	`132`
`131`	`133`	`// Iterate through all points`
`132`	`134`	`for (int[] point : points) {`
`@@ -146,4 +148,4 @@ public int[][] kClosestPointsToOriginMaxHeapApproach(int[][] points, int k) {`
`146`	`148`
`147`	`149`	`return result;`
`148`	`150`	`}`
`149`		`-}`
	`151`	`+}`

Comments

(0)