Commit 16006e0

committed

fix: order of length check in remove()

1 parent 5338710 commit 16006e0Copy full SHA for 16006e0

File tree

+17

-7

lines changed

+17

-7

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,4 +47,16 @@ describe('MaxHeap', () => {`
`47`	`47`	`expect(mh.remove()).toEqual(1);`
`48`	`48`	`expect(mh.getMax()).toEqual(null);`
`49`	`49`	`});`
	`50`	`+`
	`51`	+ it('Should return `null` on `remove() called on empty heap`', () => {
	`52`	`+ expect(mh.getMax()).toEqual(null);`
	`53`	`+ });`
	`54`	`+`
	`55`	`+ it('Should create MaxHeap using collection : [2, 12, 0, 90]', () => {`
	`56`	`+ const arr = [2, 12, 0, 90];`
	`57`	`+ const mHBulk = new MaxHeap(arr);`
	`58`	`+`
	`59`	`+ expect(mHBulk.getMax()).toEqual(90);`
	`60`	`+ // expect(mHBulk.()).toEqual(90);`
	`61`	`+ });`
`50`	`62`	`});`

Lines changed: 5 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,13 @@ class MaxHeap {`
`19`	`19`	`return this.heap[0] \|\| null;`
`20`	`20`	`}`
`21`	`21`
`22`		`- // eslint-disable-next-line consistent-return`
`23`	`22`	`remove() {`
`24`		`- // return the element at the root`
`25`	`23`	`const max = this.heap[0] \|\| null;`
	`24`	`+ // return the element at the root`
	`25`	`+ if (this.heap.length === 1) {`
	`26`	`+ this.heap.pop();`
	`27`	`+ }`
	`28`	`+`
`26`	`29`	`if (this.heap.length > 1) {`
`27`	`30`	`// move the leaf to the root`
`28`	`31`	`this.heap[0] = this.heap[this.heap.length - 1];`
`@@ -31,11 +34,6 @@ class MaxHeap {`
`31`	`34`	`// eslint-disable-next-line no-underscore-dangle`
`32`	`35`	`this.__heapify(0);`
`33`	`36`	`}`
`34`		`-`
`35`		`- if (this.heap.length === 1) {`
`36`		`- this.heap.pop();`
`37`		`- }`
`38`		`-`
`39`	`37`	`return max;`
`40`	`38`	`}`
`41`	`39`

Comments

(0)