Commit c1aaf51

committed

Reconfigure taskfile to avoid global golint dependency

The previous approach for defining the `GOLINTBIN` variable caused any use of task to fail if golint was not installed, even though the task being run might have nothing to do with golint.

1 parent d92bcbf commit c1aaf51Copy full SHA for c1aaf51

File tree

1 file changed

-3

lines changed

Taskfile.yml

1 file changed

-3

lines changed

`‎Taskfile.yml‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,9 @@ tasks:`
`61`	`61`	`desc: Lint Go code`
`62`	`62`	`cmds:`
`63`	`63`	`- go vet {{ default .DEFAULT_PACKAGES .PACKAGES }}`
`64`		`- - "'{{.GOLINTBIN}}' {{.GOLINTFLAGS}} {{ default .DEFAULT_TARGETS .TARGETS }}"`
	`64`	`+ - \|`
	`65`	`+ GOLINT_PATH="$(go list -f '{{"{{"}}.Target{{"}}"}}' golang.org/x/lint/golint \|\| echo "false")"`
	`66`	`+ "$GOLINT_PATH" {{.GOLINTFLAGS}} "{{ default .DEFAULT_TARGETS .TARGETS }}"`
`65`	`67`
`66`	`68`	`go:check-formatting:`
`67`	`69`	`desc: Check Go code formatting`
`@@ -181,8 +183,6 @@ vars:`
`181`	`183`	sh: echo '`go list -f '{{"{{"}}.Dir{{"}}"}}' ./...`'
`182`	`184`	`GOFLAGS: "-timeout 10m -v -coverpkg=./... -covermode=atomic"`
`183`	`185`
`184`		`- GOLINTBIN:`
`185`		`- sh: go list -f {{"{{"}}".Target{{"}}"}}" golang.org/x/lint/golint`
`186`	`186`	`GOLINTFLAGS: "-min_confidence 0.8 -set_exit_status"`
`187`	`187`
`188`	`188`	`PRETTIER: prettier@2.1.2`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit c1aaf51

File tree

1 file changed

1 file changed

`‎Taskfile.yml‎`

0 commit comments