Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 8fb3d1b

Browse files
committed
Only download required artifact in notarization job of release workflows
GitHub Workflows are used to automatically generate and publish production and nightly releases of the project. This is done for a range of host architectures, including macOS. The macOS builds are then put through a notarization process in a dedicated workflow job. GitHub Actions workflow artifacts are used to transfer the generated files between sequential jobs in the workflow. The builds are transferred between jobs by GitHub Actions workflow artifacts, one for each host architecture. Previously, the "notarize-macos" job matrix that performs the notarization unnecessarily downloaded all the build artifacts, even though each job only requires the relevant macOS artifact. This is inefficient. The better approach is to configure the "notarize-macos" jobs to only download the artifact they require.
1 parent 6529e20 commit 8fb3d1b

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

‎.github/workflows/publish-go-nightly-task.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,7 @@ jobs:
100100
- name: Download artifacts
101101
uses: actions/download-artifact@v4
102102
with:
103-
pattern: ${{ env.ARTIFACT_PREFIX }}*
104-
merge-multiple: true
103+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
105104
path: ${{ env.DIST_DIR }}
106105

107106
- name: Import Code-Signing Certificates

‎.github/workflows/release-go-task.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@ jobs:
109109
- name: Download artifacts
110110
uses: actions/download-artifact@v4
111111
with:
112-
pattern: ${{ env.ARTIFACT_PREFIX }}*
113-
merge-multiple: true
112+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
114113
path: ${{ env.DIST_DIR }}
115114

116115
- name: Import Code-Signing Certificates

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /