Commit 57756ad

authored

Merge pull request #173 from per1234/indexing-depends

Disable LP048 for ARDUINO_LINT_LIBRARY_MANAGER_INDEXING mode

2 parents 609854e + 809540a commit 57756adCopy full SHA for 57756ad

File tree

+13

-3

lines changed

internal/rule/ruleconfiguration
- ruleconfiguration.go
test
- test_all.py
- testdata/library-manager/ARDUINO_LINT_LIBRARY_MANAGER_INDEXING/Servo
  - Servo.h
  - library.properties

+13

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1010,7 +1010,7 @@ var configurations = []Type{`
`1010`	`1010`	`Brief: "depends not in index",`
`1011`	`1011`	`Description: "This field should be used to define the dependencies available from Library Manager. Library names are case-sensitive.",`
`1012`	`1012`	`MessageTemplate: "library.properties depends field item(s) {{.}} not found in the Library Manager index.",`
`1013`		`- DisableModes: nil,`
	`1013`	`+ DisableModes: []rulemode.Type{rulemode.LibraryManagerIndexing},`
`1014`	`1014`	`EnableModes: []rulemode.Type{rulemode.Default},`
`1015`	`1015`	`InfoModes: nil,`
`1016`	`1016`	`WarningModes: []rulemode.Type{rulemode.Default},`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -97,13 +97,13 @@ def test_library_manager_invalid(run_command):`
`97`	`97`
`98`	`98`	`def test_library_manager_indexing(run_command):`
`99`	`99`	`result = run_command(`
`100`		`- cmd=[test_data_path.joinpath("library-manager", "Update")],`
	`100`	`+ cmd=[test_data_path.joinpath("library-manager", "ARDUINO_LINT_LIBRARY_MANAGER_INDEXING", "Servo")],`
`101`	`101`	`custom_env={"ARDUINO_LINT_LIBRARY_MANAGER_INDEXING": "true"},`
`102`	`102`	`)`
`103`	`103`	`assert result.ok`
`104`	`104`
`105`	`105`	`result = run_command(`
`106`		`- cmd=[test_data_path.joinpath("library-manager", "Update")],`
	`106`	`+ cmd=[test_data_path.joinpath("library-manager", "ARDUINO_LINT_LIBRARY_MANAGER_INDEXING", "Servo")],`
`107`	`107`	`custom_env={"ARDUINO_LINT_LIBRARY_MANAGER_INDEXING": "foo"},`
`108`	`108`	`)`
`109`	`109`	`assert not result.ok`

Whitespace-only changes.

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,10 @@`
	`1`	`+name=Servo`
	`2`	`+version=1.1.7`
	`3`	`+author=Michael Margolis, Arduino`
	`4`	`+maintainer=Arduino <info@arduino.cc>`
	`5`	`+sentence=Allows Arduino/Genuino boards to control a variety of servo motors.`
	`6`	`+paragraph=This library can control a great number of servos.<br />It makes careful use of timers: the library can control 12 servos using only 1 timer.<br />On the Arduino Due you can control up to 60 servos.<br />`
	`7`	`+category=Device Control`
	`8`	`+url=http://www.arduino.cc/en/Reference/Servo`
	`9`	`+architectures=avr,megaavr,sam,samd,nrf52,stm32f4,mbed`
	`10`	`+depends=Arduino_nonexistent`

Comments

(0)