Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 4949c82

Browse files
committed
Remove unnecessary recursive .npmrc coverage from workflow path filters
For the sake of efficiency, GitHub Workflows should be configured to only be triggered when relevant files are modified. This filtering is done via the `paths` mapping. "Globstar" patterns are supported in paths filters. This will cause the filter to match the matching files in any path under the repository. Previously, this was done for the `.npmrc` npm configuration file in various workflows. Although this is appropriate in the "Check npm" workflow, which supports checking npm-based projects in subfolders of the repository, it is not appropriate for the other workflows which do not have such support (and likely don't need it). In order to improve the efficiency of the workflows, the globstars are removed from the `.npmrc` path filters in the workflows where it is not appropriate.
1 parent 512c586 commit 4949c82

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

‎.github/workflows/check-markdown-task.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
paths:
99
- ".github/workflows/check-markdown-task.ya?ml"
1010
- ".markdown-link-check.json"
11-
- "**/.npmrc"
11+
- ".npmrc"
1212
- "package.json"
1313
- "package-lock.json"
1414
- "Taskfile.ya?ml"
@@ -23,7 +23,7 @@ on:
2323
paths:
2424
- ".github/workflows/check-markdown-task.ya?ml"
2525
- ".markdown-link-check.json"
26-
- "**/.npmrc"
26+
- ".npmrc"
2727
- "package.json"
2828
- "package-lock.json"
2929
- "Taskfile.ya?ml"

‎.github/workflows/check-prettier-formatting-task.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ on:
77
push:
88
paths:
99
- ".github/workflows/check-prettier-formatting-task.ya?ml"
10+
- ".npmrc"
1011
- "Taskfile.ya?ml"
11-
- "**/.npmrc"
1212
- "**/.prettierignore"
1313
- "**/.prettierrc*"
1414
# CSS
@@ -111,8 +111,8 @@ on:
111111
pull_request:
112112
paths:
113113
- ".github/workflows/check-prettier-formatting-task.ya?ml"
114+
- ".npmrc"
114115
- "Taskfile.ya?ml"
115-
- "**/.npmrc"
116116
- "**/.prettierignore"
117117
- "**/.prettierrc*"
118118
# CSS

‎.github/workflows/check-workflows-task.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ on:
66
push:
77
paths:
88
- ".github/workflows/*.ya?ml"
9-
- "**/.npmrc"
9+
- ".npmrc"
1010
- "package.json"
1111
- "package-lock.json"
1212
- "Taskfile.ya?ml"
1313
pull_request:
1414
paths:
1515
- ".github/workflows/*.ya?ml"
16-
- "**/.npmrc"
16+
- ".npmrc"
1717
- "package.json"
1818
- "package-lock.json"
1919
- "Taskfile.ya?ml"

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /