-
-
Notifications
You must be signed in to change notification settings - Fork 488
fix: disable open keymap split editor from toolbar #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complete support for split editor is yet to be added to IDE2. For now, this commit turns off opening the keymaps in the JSON split editor. So that it cannot get the primary IDE2 layout into an inconsistent state. Closes #1850 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Feb 23, 2024
@kittaakos
kittaakos
requested review from
giacomocusinato and
davegarthsimpson
February 23, 2024 14:38
giacomocusinato
giacomocusinato
approved these changes
Feb 23, 2024
CLAassistant
commented
Apr 1, 2024
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The complete support for split editor is yet to be added to IDE2. For now, this commit turns off opening the keymaps in the JSON split editor. So that it cannot get the primary IDE2 layout into an inconsistent state.
Change description
Other information
Closes #1850
Reviewer checklist