Commit d2a6f38

author

Akos Kitta

committed

feat: simplify board and port handling

Closes #1319 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent e17472e commit d2a6f38Copy full SHA for d2a6f38

File tree

52 files changed

+3044

-3052

lines changed

arduino-ide-extension/src
- browser
  - arduino-ide-frontend-module.ts
  - boards
  - contributions
  - dialogs
    - certificate-uploader
    - firmware-uploader
      - firmware-uploader-component.tsx
      - firmware-uploader-dialog.tsx
  - monitor-manager-proxy-client-impl.ts
  - notification-center.ts
  - serial/monitor
    - monitor-widget.tsx
  - style
    - boards-config-dialog.css
  - theia/dialogs
    - dialogs.tsx
- common
- node
- test
  - browser
    - boards-auto-installer.test.ts
    - fixtures
      - boards.ts
  - common
    - board-list.test.ts
    - boards-service.test.ts
  - node
    - core-service-impl.test.ts
    - test-bindings.ts
i18n
- en.json

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+3044

-3052

lines changed

`‎arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts‎`

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,10 @@ import { SketchesServiceClientImpl } from './sketches-service-client-impl';`
`27`	`27`	`import { CoreService, CoreServicePath } from '../common/protocol/core-service';`
`28`	`28`	`import { BoardsListWidget } from './boards/boards-list-widget';`
`29`	`29`	`import { BoardsListWidgetFrontendContribution } from './boards/boards-widget-frontend-contribution';`
`30`		`-import { BoardsServiceProvider } from './boards/boards-service-provider';`
	`30`	`+import {`
	`31`	`+ BoardListDumper,`
	`32`	`+ BoardsServiceProvider,`
	`33`	`+} from './boards/boards-service-provider';`
`31`	`34`	`import { WorkspaceService as TheiaWorkspaceService } from '@theia/workspace/lib/browser/workspace-service';`
`32`	`35`	`import { WorkspaceService } from './theia/workspace/workspace-service';`
`33`	`36`	`import { OutlineViewContribution as TheiaOutlineViewContribution } from '@theia/outline-view/lib/browser/outline-view-contribution';`
`@@ -61,7 +64,6 @@ import {`
`61`	`64`	`BoardsConfigDialog,`
`62`	`65`	`BoardsConfigDialogProps,`
`63`	`66`	`} from './boards/boards-config-dialog';`
`64`		`-import { BoardsConfigDialogWidget } from './boards/boards-config-dialog-widget';`
`65`	`67`	`import { ScmContribution as TheiaScmContribution } from '@theia/scm/lib/browser/scm-contribution';`
`66`	`68`	`import { ScmContribution } from './theia/scm/scm-contribution';`
`67`	`69`	`import { SearchInWorkspaceFrontendContribution as TheiaSearchInWorkspaceFrontendContribution } from '@theia/search-in-workspace/lib/browser/search-in-workspace-frontend-contribution';`
`@@ -358,7 +360,7 @@ import { UpdateArduinoState } from './contributions/update-arduino-state';`
`358`	`360`	`import { TerminalWidgetImpl } from './theia/terminal/terminal-widget-impl';`
`359`	`361`	`import { TerminalWidget } from '@theia/terminal/lib/browser/base/terminal-widget';`
`360`	`362`	`import { TerminalFrontendContribution } from './theia/terminal/terminal-frontend-contribution';`
`361`		`-import { TerminalFrontendContribution as TheiaTerminalFrontendContribution } from '@theia/terminal/lib/browser/terminal-frontend-contribution'`
	`363`	`+import { TerminalFrontendContribution as TheiaTerminalFrontendContribution } from '@theia/terminal/lib/browser/terminal-frontend-contribution';`
`362`	`364`
`363`	`365`	`// Hack to fix copy/cut/paste issue after electron version update in Theia.`
`364`	`366`	`// https://github.com/eclipse-theia/theia/issues/12487`
`@@ -447,6 +449,7 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {`
`447`	`449`	`bind(BoardsServiceProvider).toSelf().inSingletonScope();`
`448`	`450`	`bind(FrontendApplicationContribution).toService(BoardsServiceProvider);`
`449`	`451`	`bind(CommandContribution).toService(BoardsServiceProvider);`
	`452`	`+ bind(BoardListDumper).toSelf().inSingletonScope();`
`450`	`453`
`451`	`454`	`// To be able to track, and update the menu based on the core settings (aka. board details) of the currently selected board.`
`452`	`455`	`bind(FrontendApplicationContribution)`
`@@ -480,7 +483,6 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {`
`480`	`483`	`bind(OpenHandler).toService(BoardsListWidgetFrontendContribution);`
`481`	`484`
`482`	`485`	`// Board select dialog`
`483`		`- bind(BoardsConfigDialogWidget).toSelf().inSingletonScope();`
`484`	`486`	`bind(BoardsConfigDialog).toSelf().inSingletonScope();`
`485`	`487`	`bind(BoardsConfigDialogProps).toConstantValue({`
`486`	`488`	`title: nls.localize(`
`@@ -1034,5 +1036,7 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {`
`1034`	`1036`	`// Patch terminal issues.`
`1035`	`1037`	`rebind(TerminalWidget).to(TerminalWidgetImpl).inTransientScope();`
`1036`	`1038`	`bind(TerminalFrontendContribution).toSelf().inSingletonScope();`
`1037`		`- rebind(TheiaTerminalFrontendContribution).toService(TerminalFrontendContribution);`
	`1039`	`+ rebind(TheiaTerminalFrontendContribution).toService(`
	`1040`	`+ TerminalFrontendContribution`
	`1041`	`+ );`
`1038`	`1042`	`});`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit d2a6f38

File tree

52 files changed

Some content is hidden

52 files changed

`‎arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts‎`

0 commit comments