Commit cc2d557

Akos Kittakittaakos

Akos Kitta

authored and

committed

fix: relaxed condition to check if resource exists

The original (`fs-extra`-based) implementation did not check if the file is writable either. Resources are not writable in mounted AppImages. Closes #1586 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent 103acc4 commit cc2d557Copy full SHA for cc2d557

File tree

1 file changed

-1

lines changed

arduino-ide-extension/src/node
- sketches-service-impl.ts

1 file changed

-1

lines changed

`‎arduino-ide-extension/src/node/sketches-service-impl.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -660,7 +660,7 @@ export class SketchesServiceImpl`
`660`	`660`
`661`	`661`	`private async exists(pathLike: string): Promise<boolean> {`
`662`	`662`	`try {`
`663`		`- await fs.access(pathLike, constants.R_OK\|constants.W_OK);`
	`663`	`+ await fs.access(pathLike, constants.R_OK);`
`664`	`664`	`return true;`
`665`	`665`	`} catch {`
`666`	`666`	`return false;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit cc2d557

File tree

1 file changed

1 file changed

`‎arduino-ide-extension/src/node/sketches-service-impl.ts‎`

0 commit comments