Commit bfcb518

author

Akos Kitta

committed

fix: revive --theia-icon-loading in IDE2

- it has been removed from Theia - aligned the DOM structure to previous the version when using widget Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent f338106 commit bfcb518Copy full SHA for bfcb518

File tree

+33

-14

lines changed

+33

-14

lines changed

Lines changed: 11 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -67,15 +67,17 @@ export class UploadFirmwareDialog extends ReactDialog<void> {`
`67`	`67`
`68`	`68`	`protected override render(): React.ReactNode {`
`69`	`69`	`return (`
`70`		`- <form>`
`71`		`- <FirmwareUploaderComponent`
`72`		`- availableBoards={this.availableBoards}`
`73`		`- firmwareUploader={this.arduinoFirmwareUploader}`
`74`		`- flashFirmware={this.flashFirmware.bind(this)}`
`75`		`- updatableFqbns={this.updatableFqbns}`
`76`		`- isOpen={this.isOpen}`
`77`		`- />`
`78`		`- </form>`
	`70`	`+ <div>`
	`71`	`+ <form>`
	`72`	`+ <FirmwareUploaderComponent`
	`73`	`+ availableBoards={this.availableBoards}`
	`74`	`+ firmwareUploader={this.arduinoFirmwareUploader}`
	`75`	`+ flashFirmware={this.flashFirmware.bind(this)}`
	`76`	`+ updatableFqbns={this.updatableFqbns}`
	`77`	`+ isOpen={this.isOpen}`
	`78`	`+ />`
	`79`	`+ </form>`
	`80`	`+ </div>`
`79`	`81`	`);`
`80`	`82`	`}`
`81`	`83`
`@@ -86,11 +88,6 @@ export class UploadFirmwareDialog extends ReactDialog<void> {`
`86`	`88`	`this.update();`
`87`	`89`	`}`
`88`	`90`
`89`		`- protected override onUpdateRequest(msg: Message): void {`
`90`		`- super.onUpdateRequest(msg);`
`91`		`- this.update();`
`92`		`- }`
`93`		`-`
`94`	`91`	`// eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars`
`95`	`92`	`protected override handleEnter(event: KeyboardEvent): boolean \| void {`
`96`	`93`	`return false;`

Lines changed: 6 additions & 0 deletions

Lines changed: 6 additions & 0 deletions

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,16 @@`
`20`	`20`	`@import './progress-bar.css';`
`21`	`21`	`@import './settings-step-input.css';`
`22`	`22`
	`23`	+/* Revive of the `--theia-icon-loading`. The variable has been removed from Theia while IDE2 still uses is. */
	`24`	`+/* The SVG icons are still part of Theia (1.31.1) */`
	`25`	`+/* https://github.com/arduino/arduino-ide/pull/1662#issuecomment-1324997134 */`
	`26`	`+body {`
	`27`	`+ --theia-icon-loading: url(../icons/loading-light.svg);`
	`28`	`+}`
	`29`	`+body.theia-dark {`
	`30`	`+ --theia-icon-loading: url(../icons/loading-dark.svg);`
	`31`	`+}`
	`32`	`+`
`23`	`33`	`.theia-input.warning:focus {`
`24`	`34`	`outline-width: 1px;`
`25`	`35`	`outline-style: solid;`

Comments

(0)