Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit bb4b145

Browse files
Akos Kittakittaakos
Akos Kitta
authored andcommitted
chore: use Node.js >=18.17.0
remove `msvs_version` npm config on win32 Ref: nodejs/node-gyp#2822 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent 8a5dee9 commit bb4b145

File tree

8 files changed

+21
-92
lines changed

8 files changed

+21
-92
lines changed

‎.github/workflows/build.yml‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ jobs:
8585
- name: Checkout
8686
uses: actions/checkout@v4
8787

88-
- name: Install Node.js 16.14
88+
- name: Install Node.js 18.17
8989
uses: actions/setup-node@v3
9090
with:
91-
node-version: '16.14'
91+
node-version: '18.17'
9292
registry-url: 'https://registry.npmjs.org'
9393
cache: 'yarn'
9494

@@ -131,10 +131,6 @@ jobs:
131131
export CSC_FOR_PULL_REQUEST=true
132132
fi
133133
134-
if [ "${{ runner.OS }}" = "Windows" ]; then
135-
npm config set msvs_version 2017 --global
136-
fi
137-
138134
npx node-gyp install
139135
yarn install --immutable
140136

‎.github/workflows/check-i18n-task.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ jobs:
5858
- name: Checkout repository
5959
uses: actions/checkout@v4
6060

61-
- name: Install Node.js 16.14
61+
- name: Install Node.js 18.17
6262
uses: actions/setup-node@v3
6363
with:
64-
node-version: '16.14'
64+
node-version: '18.17'
6565
registry-url: 'https://registry.npmjs.org'
6666
cache: 'yarn'
6767

‎.github/workflows/compose-full-changelog.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
env:
99
CHANGELOG_ARTIFACTS: changelog
1010
# See: https://github.com/actions/setup-node/#readme
11-
NODE_VERSION: 16.x
11+
NODE_VERSION: '18.17'
1212

1313
jobs:
1414
create-changelog:

‎.github/workflows/i18n-nightly-push.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v4
1818

19-
- name: Install Node.js 16.14
19+
- name: Install Node.js 18.17
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: '16.14'
22+
node-version: '18.17'
2323
registry-url: 'https://registry.npmjs.org'
2424
cache: 'yarn'
2525

‎.github/workflows/i18n-weekly-pull.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v4
1818

19-
- name: Install Node.js 16.14
19+
- name: Install Node.js 18.17
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: '16.14'
22+
node-version: '18.17'
2323
registry-url: 'https://registry.npmjs.org'
2424
cache: 'yarn'
2525

‎docs/internal/Arm.md‎

Lines changed: 0 additions & 71 deletions
This file was deleted.

‎docs/internal/Ubuntu.md‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
### Building and start the app from the sources on Ubuntu Linux
22

3-
Tested and verified on Ubuntu 18.04.4. The source will be checked out to `~/dev/git/arduino-ide`.
3+
Tested and verified on Ubuntu 22.04. The source will be checked out to `~/dev/git/arduino-ide`.
4+
5+
> ❗ This is an all-in-one script to create production-ready, minified code; you will need ~16GB of RAM to run it. This script will install libraries you might already have on your system and change the default Node.js version you do not want. If you look for documentation on development, please reference [this](../development.md#prerequisites) section instead.
46
57
```
68
#!/bin/bash -i
@@ -11,23 +13,25 @@ sudo apt update \
1113
gcc \
1214
curl \
1315
make \
14-
python \
16+
python3 \
1517
pkg-config \
1618
libx11-dev \
1719
libxkbfile-dev \
1820
build-essential \
21+
libsecret-1-dev \
1922
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
2023
&& source ~/.bashrc \
21-
&& nvm install 16 \
22-
&& nvm use 16 \
23-
&& nvm alias default 16 \
24+
&& nvm install 18.17 \
25+
&& nvm use 18.17 \
26+
&& nvm alias default 18.17 \
2427
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
2528
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
2629
&& sudo apt update && sudo apt install --no-install-recommends yarn \
2730
&& mkdir -p ~/dev/git/ \
2831
&& rm -rf ~/dev/git/arduino-ide \
2932
&& git clone --depth 1 https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
3033
&& yarn --cwd ~/dev/git/arduino-ide \
31-
&& yarn --cwd ~/dev/git/arduino-ide rebuild:electron \
32-
&& yarn --cwd ~/dev/git/arduino-ide/electron-app start
34+
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
35+
&& yarn --cwd ~/dev/git/arduino-ide build \
36+
&& yarn --cwd ~/dev/git/arduino-ide start
3337
```

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "AGPL-3.0-or-later",
88
"private": true,
99
"engines": {
10-
"node": ">=16.14.0 <17"
10+
"node": ">=18.17.0 <21"
1111
},
1212
"devDependencies": {
1313
"@theia/cli": "1.39.0",

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /