Commit 9a2d13f

author

Akos Kitta

committed

Fixed dirty indicator of uncloseable widgets.

Closes #1034. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent b7dbe59 commit 9a2d13fCopy full SHA for 9a2d13f

File tree

-3

lines changed

arduino-ide-extension/src/browser
- style
  - editor.css
- theia/core
  - widget-manager.ts

-3

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,7 @@`
`1`	`1`	`/* Show the dirty indicator on unclosable widgets. On hover, it should still show the dot instead of the X. */`
`2`	`2`	`/* https://github.com/arduino/arduino-pro-ide/issues/380 */`
`3`		`-.p-TabBar.theia-app-centers .p-TabBar-tab.p-mod-closable.theia-mod-dirty > .p-TabBar-tabCloseIcon:hover {`
`4`		`- background-size: 13px;`
`5`		`- background-image: var(--theia-icon-circle);`
	`3`	`+.p-TabBar.theia-app-centers .p-TabBar-tab.p-mod-closable.a-mod-uncloseable.theia-mod-dirty > .p-TabBar-tabCloseIcon:before {`
	`4`	`+ content: "\ea71";`
`6`	`5`	`}`
`7`	`6`
`8`	`7`	`.monaco-list-row.show-file-icons.focused {`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,11 @@ export class WidgetManager extends TheiaWidgetManager {`
`66`	`66`	`if (title.closable) {`
`67`	`67`	`title.closable = false;`
`68`	`68`	`}`
	`69`	+ // Show the dirty indicator on uncloseable widgets when hovering over the title. Instead of showing the `X` for close.
	`70`	`+ const uncloseableClass = 'a-mod-uncloseable';`
	`71`	`+ if (!title.className.includes(uncloseableClass)) {`
	`72`	+ title.className += title.className + ` ${uncloseableClass}`;
	`73`	`+ }`
`69`	`74`	`}`
`70`	`75`
`71`	`76`	`/**`

Comments

(0)