Commit 87ebcbe

Akos Kittakittaakos

Akos Kitta

authored and

committed

Let CSS do the uppercase transformation.

Expose no implementation details to translation files. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent 99b1094 commit 87ebcbeCopy full SHA for 87ebcbe

File tree

5 files changed

+12

-13

lines changed

arduino-ide-extension/src/browser
- style
  - index.css
  - list-widget.css
- widgets
  - cloud-sketchbook
    - cloud-sketchbook-tree-widget.tsx
  - component-list
    - list-item-renderer.tsx
i18n
- en.json

5 files changed

+12

-13

lines changed

`‎arduino-ide-extension/src/browser/style/index.css‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,9 @@ button.secondary[disabled], .theia-button.secondary[disabled] {`
`137`	`137`	`font-size: 14px;`
`138`	`138`	`}`
`139`	`139`
	`140`	`+.uppercase {`
	`141`	`+ text-transform: uppercase;`
	`142`	`+}`
`140`	`143`
`141`	`144`	`/* High Contrast Theme rules */`
`142`	`145`	`/* TODO: Remove it when the Theia version is upgraded to 1.27.0 and use Theia APIs to implement it*/`

`‎arduino-ide-extension/src/browser/style/list-widget.css‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -112,14 +112,12 @@`
`112`	`112`	`max-height: calc(1em + 4px);`
`113`	`113`	`color: var(--theia-button-foreground);`
`114`	`114`	`content: attr(install);`
`115`		`- text-transform: uppercase;`
`116`	`115`	`}`
`117`	`116`
`118`	`117`	`.component-list-item .header .installed:hover:before {`
`119`	`118`	`background-color: var(--theia-button-foreground);`
`120`	`119`	`color: var(--theia-button-background);`
`121`	`120`	`content: attr(uninstall);`
`122`		`- text-transform: uppercase;`
`123`	`121`	`}`
`124`	`122`
`125`	`123`	`.component-list-item[min-width~="170px"] .footer {`

`‎arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,10 +61,10 @@ export class CloudSketchbookTreeWidget extends SketchbookTreeWidget {`
`61`	`61`	`</div>`
`62`	`62`	`</div>`
`63`	`63`	`<button`
`64`		`- className="theia-button"`
	`64`	`+ className="theia-button uppercase"`
`65`	`65`	`onClick={() => shell.openExternal('https://create.arduino.cc/editor')}`
`66`	`66`	`>`
`67`		`- {nls.localize('cloud/GoToCloud', 'GO TO CLOUD')}`
	`67`	`+ {nls.localize('arduino/cloud/goToCloud', 'Go to Cloud')}`
`68`	`68`	`</button>`
`69`	`69`	`<div className="center item"></div>`
`70`	`70`	`</div>`

`‎arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {`
`56`	`56`	`)}`
`57`	`57`	`</span>`
`58`	`58`	`<span`
`59`		`- className="installed"`
	`59`	`+ className="installed uppercase"`
`60`	`60`	`onClick={onClickUninstall}`
`61`	`61`	`{...{`
`62`		`- install: nls.localize('arduino/component/installed', 'INSTALLED'),`
	`62`	`+ install: nls.localize('arduino/component/installed', 'Installed'),`
`63`	`63`	`uninstall: nls.localize('arduino/component/uninstall', 'Uninstall'),`
`64`	`64`	`}}`
`65`	`65`	`/>`
`@@ -77,10 +77,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {`
`77`	`77`	`const onClickInstall = () => install(item);`
`78`	`78`	`const installButton = item.installable && (`
`79`	`79`	`<button`
`80`		`- className="theia-button secondary install"`
	`80`	`+ className="theia-button secondary install uppercase"`
`81`	`81`	`onClick={onClickInstall}`
`82`	`82`	`>`
`83`		`- {nls.localize('arduino/component/install', 'INSTALL')}`
	`83`	`+ {nls.localize('arduino/component/install', 'Install')}`
`84`	`84`	`</button>`
`85`	`85`	`);`
`86`	`86`

`‎i18n/en.json‎`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@`
`90`	`90`	`"donePushing": "Done pushing ‘{0}’.",`
`91`	`91`	`"embed": "Embed:",`
`92`	`92`	`"emptySketchbook": "Your Sketchbook is empty",`
	`93`	`+ "goToCloud": "Go to Cloud",`
`93`	`94`	`"learnMore": "Learn more",`
`94`	`95`	`"link": "Link:",`
`95`	`96`	`"notYetPulled": "Cannot push to Cloud. It is not yet pulled.",`
`@@ -144,8 +145,8 @@`
`144`	`145`	`"boardsIncluded": "Boards included in this package:",`
`145`	`146`	`"by": "by",`
`146`	`147`	`"filterSearch": "Filter your search...",`
`147`		`- "install": "INSTALL",`
`148`		`- "installed": "INSTALLED",`
	`148`	`+ "install": "Install",`
	`149`	`+ "installed": "Installed",`
`149`	`150`	`"moreInfo": "More info",`
`150`	`151`	`"uninstall": "Uninstall",`
`151`	`152`	`"uninstallMsg": "Do you want to uninstall {0}?",`
`@@ -422,9 +423,6 @@`
`422`	`423`	`"upload": "Upload"`
`423`	`424`	`}`
`424`	`425`	`},`
`425`		`- "cloud": {`
`426`		`- "GoToCloud": "GO TO CLOUD"`
`427`		`- },`
`428`	`426`	`"theia": {`
`429`	`427`	`"core": {`
`430`	`428`	`"cannotConnectBackend": "Cannot connect to the backend.",`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 87ebcbe

File tree

5 files changed

5 files changed

`‎arduino-ide-extension/src/browser/style/index.css‎`

`‎arduino-ide-extension/src/browser/style/list-widget.css‎`

`‎arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx‎`

`‎arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx‎`

`‎i18n/en.json‎`

0 commit comments