Commit 6f5feb3

author

Akos Kitta

committed

fix: platform release version ordering

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent d5b0a4d commit 6f5feb3Copy full SHA for 6f5feb3

File tree

2 files changed

+28

-2

lines changed

arduino-ide-extension/src
- node
  - boards-service-impl.ts
- test/node
  - boards-service-impl.slow-test.ts

2 files changed

+28

-2

lines changed

`‎arduino-ide-extension/src/node/boards-service-impl.ts‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -589,6 +589,9 @@ function createBoardsPackage(`
`589`	`589`	`return undefined; // never show incompatible platforms`
`590`	`590`	`}`
`591`	`591`	`const { id, website, maintainer } = summary.metadata;`
	`592`	`+ const availableVersions = Array.from(versionReleaseMap.keys())`
	`593`	`+ .sort(Installable.Version.COMPARATOR)`
	`594`	`+ .reverse();`
`592`	`595`	`return {`
`593`	`596`	`id,`
`594`	`597`	`name,`
`@@ -602,7 +605,7 @@ function createBoardsPackage(`
`602`	`605`	`moreInfoLink: website,`
`603`	`606`	`author: maintainer,`
`604`	`607`	`deprecated,`
`605`		`- availableVersions: Array.from(versionReleaseMap.keys()),`
	`608`	`+ availableVersions,`
`606`	`609`	`};`
`607`	`610`	`}`
`608`	`611`

`‎arduino-ide-extension/src/test/node/boards-service-impl.slow-test.ts‎`

Lines changed: 24 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { DisposableCollection } from '@theia/core/lib/common/disposable';`
`2`	`2`	`import { Container } from '@theia/core/shared/inversify';`
`3`	`3`	`import { expect } from 'chai';`
`4`		`-import { BoardSearch, BoardsService } from '../../common/protocol';`
	`4`	`+import { BoardSearch, BoardsService,Installable } from '../../common/protocol';`
`5`	`5`	`import { createBaseContainer, startDaemon } from './node-test-bindings';`
`6`	`6`
`7`	`7`	`describe('boards-service-impl', () => {`
`@@ -24,6 +24,29 @@ describe('boards-service-impl', () => {`
`24`	`24`	`expect(result).is.not.empty;`
`25`	`25`	`});`
`26`	`26`
	`27`	`+ it('should order the available platform release versions in descending order', async function () {`
	`28`	`+ const result = await boardService.search({});`
	`29`	`+ result.forEach((platform) =>`
	`30`	`+ platform.availableVersions.forEach(`
	`31`	`+ (currentVersion, index, versions) => {`
	`32`	`+ if (index < versions.length - 2) {`
	`33`	`+ const nextArrayElement = versions[index + 1];`
	`34`	`+ const actual = Installable.Version.COMPARATOR(`
	`35`	`+ currentVersion,`
	`36`	`+ nextArrayElement`
	`37`	`+ );`
	`38`	`+ expect(actual).to.be.greaterThan(`
	`39`	`+ 0,`
	`40`	+ `Expected '${currentVersion}' to be gt '${nextArrayElement}'. All versions: ${JSON.stringify(
	`41`	`+ versions`
	`42`	+ )}`
	`43`	`+ );`
	`44`	`+ }`
	`45`	`+ }`
	`46`	`+ )`
	`47`	`+ );`
	`48`	`+ });`
	`49`	`+`
`27`	`50`	`it("should boost a result when 'types' includes 'arduino', and lower the score if deprecated", async () => {`
`28`	`51`	`const result = await boardService.search({});`
`29`	`52`	`const arduinoIndexes: number[] = [];`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 6f5feb3

File tree

2 files changed

2 files changed

`‎arduino-ide-extension/src/node/boards-service-impl.ts‎`

`‎arduino-ide-extension/src/test/node/boards-service-impl.slow-test.ts‎`

0 commit comments