Commit 57bc7d8

author

Akos Kitta

committed

fix: revert unnecessary await

💄 test suite description + dev comments Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent 808fbe4 commit 57bc7d8Copy full SHA for 57bc7d8

File tree

2 files changed

+10

-4

lines changed

arduino-ide-extension/src/test/node
- core-client-provider.slow-test.ts
- test-bindings.ts

2 files changed

+10

-4

lines changed

`‎arduino-ide-extension/src/test/node/core-client-provider.slow-test.ts‎`

Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,10 @@ describe('core-client-provider', () => {`
`45`	`45`	`});`
`46`	`46`	`});`
`47`	`47`
	`48`	`+ // The better translation the CLI has, the more likely IDE2 won't be able to detect primary package and library index errors.`
	`49`	`+ // Instead of running the test against all supported locales, IDE2 runs the tests with locales that result in a bug.`
`48`	`50`	`['it', 'de'].map(([locale]) =>`
`49`		- it(`should recover from the missing 'directories.data' independently from the CLI locale: '${locale}'`, async function () {
	`51`	+ it(`should recover when the 'directories.data' folder is missing independently from the CLI's locale ('${locale}')`, async function () {
`50`	`52`	`this.timeout(timeout);`
`51`	`53`	`const configDirPath = await prepareTestConfigDir({ locale });`
`52`	`54`
`@@ -59,7 +61,7 @@ describe('core-client-provider', () => {`
`59`	`61`	`})`
`60`	`62`	`);`
`61`	`63`
`62`		`- it("should recover all when the 'directories.data' folder is missing", async function () {`
	`64`	`+ it("should recover when the 'directories.data' folder is missing", async function () {`
`63`	`65`	`this.timeout(timeout);`
`64`	`66`	`const configDirPath = await prepareTestConfigDir();`
`65`	`67`	`deleteSync(join(configDirPath, 'data'));`
`@@ -106,7 +108,12 @@ describe('core-client-provider', () => {`
`106`	`108`	`});`
`107`	`109`
`108`	`110`	`['serial-discovery', 'mdns-discovery'].map((tool) =>`
`109`		- it(`should recover the platform tools when the 'tools/${tool}' location is missing inside the 'directories.data/packages' folder`, async function () {
	`111`	+ it(`should recover when the '${join(
	`112`	`+ 'packages',`
	`113`	`+ 'builtin',`
	`114`	`+ 'tools',`
	`115`	`+ tool`
	`116`	+ )}' folder is missing`, async function () {
`110`	`117`	`this.timeout(timeout);`
`111`	`118`	`const configDirPath = await prepareTestConfigDir();`
`112`	`119`	`const builtinToolsPath = join(`

`‎arduino-ide-extension/src/test/node/test-bindings.ts‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,6 @@ export async function startDaemon(`
`407`	`407`	`container.get<CoreClientProvider>(CoreClientProvider);`
`408`	`408`	`toDispose.push(Disposable.create(() => daemon.stop()));`
`409`	`409`	`configService.onStart();`
`410`		- await configService.getConfiguration(); // ensure the config service is ready with the modified `directories` props.
`411`	`410`	`daemon.onStart();`
`412`	`411`	`await Promise.all([`
`413`	`412`	`waitForEvent(daemon.onDaemonStarted, 10_000),`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 57bc7d8

File tree

2 files changed

2 files changed

`‎arduino-ide-extension/src/test/node/core-client-provider.slow-test.ts‎`

`‎arduino-ide-extension/src/test/node/test-bindings.ts‎`

0 commit comments