Commit 4398f66

author

Akos Kitta

committed

fix: execute the Arduino CLI without a shell

Closes #2112 Ref: #2067 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent b256655 commit 4398f66Copy full SHA for 4398f66

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,10 +173,9 @@ export class ArduinoDaemonImpl`
`173`	`173`	`const cliPath = this.getExecPath();`
`174`	`174`	`const ready = new Deferred<{ daemon: ChildProcess; port: string }>();`
`175`	`175`	`const options = {`
`176`		`- shell: true,`
`177`	`176`	`env: { ...deepClone(process.env), NO_COLOR: String(true) },`
`178`	`177`	`};`
`179`		- const daemon = spawn(`"${cliPath}"`, args, options);
	`178`	`+ const daemon = spawn(cliPath, args, options);`
`180`	`179`
`181`	`180`	`// If the process exists right after the daemon gRPC server has started (due to an invalid port, unknown address, TCP port in use, etc.)`
`182`	`181`	`// we have no idea about the root cause unless we sniff into the first data package and dispatch the logic on that. Note, we get a exit code 1.`

Comments

(0)