Commit 3f05396

wh201906per1234

and

authored

Replace socks with socks5 in proxy protocol (#1776)

The net/http package in arduino-cli supports socks5 as scheme rather than socks. Co-authored-by: per1234 <accounts@perglass.com>

1 parent 644e607 commit 3f05396Copy full SHA for 3f05396

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ export class SettingsComponent extends React.Component<`
`406`	`406`	`}`
`407`	`407`	`onChange={this.socksProtocolDidChange}`
`408`	`408`	`/>`
`409`		`- SOCKS`
	`409`	`+ SOCKS5`
`410`	`410`	`</label>`
`411`	`411`	`</form>`
`412`	`412`	`<div className="flex-line proxy-settings">`
`@@ -682,7 +682,7 @@ export class SettingsComponent extends React.Component<`
`682`	`682`	`): void => {`
`683`	`683`	`if (this.state.network !== 'none') {`
`684`	`684`	`const network = this.cloneProxySettings;`
`685`		`- network.protocol = event.target.checked ? 'http' : 'socks';`
	`685`	`+ network.protocol = event.target.checked ? 'http' : 'socks5';`
`686`	`686`	`this.setState({ network });`
`687`	`687`	`}`
`688`	`688`	`};`
`@@ -692,7 +692,7 @@ export class SettingsComponent extends React.Component<`
`692`	`692`	`): void => {`
`693`	`693`	`if (this.state.network !== 'none') {`
`694`	`694`	`const network = this.cloneProxySettings;`
`695`		`- network.protocol = event.target.checked ? 'socks' : 'http';`
	`695`	`+ network.protocol = event.target.checked ? 'socks5' : 'http';`
`696`	`696`	`this.setState({ network });`
`697`	`697`	`}`
`698`	`698`	`};`

Comments

(0)