Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 0fe0fea

Browse files
committed
Get job-specific configuration from matrix in build workflow
The "build" workflow builds the application for a range of target hosts. This is done by using a job matrix. A separate parallel job runs for each target. The target-specific configuration data is defined in the job matrix array. This configuration data includes the information related to the code signing certificates. Inexplicably, during the work to add support for signing the Windows builds with an "eToken" hardware authentication device, this data was not used for the Windows code signing configuration. Instead the certificate data was redundantly hardcoded into the workflow code. The Windows code signing certificate configuration is hereby changed to use the established flexible job configuration data system. This makes the workflow easier to understand and maintain.
1 parent 43f0ccb commit 0fe0fea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎.github/workflows/build.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ jobs:
288288
# We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
289289
# Keep in mind that this path could change when upgrading to a new runner version
290290
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
291-
WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }}
292-
WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }}
291+
WIN_CERT_PASSWORD: ${{ secrets[matrix.config.certificate-password-secret] }}
292+
WIN_CERT_CONTAINER_NAME: ${{ secrets[matrix.config.certificate-container] }}
293293
WIN_SIGNING_ENABLED: ${{ !github.event.pull_request.head.repo.fork }}
294294

295295
strategy:

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /