Commit 9b2ba95

committed

Enable pulseIn() sketches for Portenta in sketch compilation workflow

At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a `pulseIn()` function. Although this was a legitimate bug, since this was an issue with the `arduino/ArduinoCore-mbed` code base, already tracked there, and unrelated to the code hosted in this repository, it was determined that the best approach would be to configure the workflow to not compile the examples that used `pulseIn()` for the Portenta H7. Since that time, `pulseIn()` has been implemented for Portenta H7 and so we can now compile these sketches for that board.

1 parent 759c03b commit 9b2ba95Copy full SHA for 9b2ba95

File tree

1 file changed

-3

lines changed

.github/workflows
- compile-examples.yml

1 file changed

-3

lines changed

`‎.github/workflows/compile-examples.yml‎`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,7 @@ jobs:`
`132`	`132`	`serial1: true`
`133`	`133`	`starter-kit: false`
`134`	`134`	`tone: true`
`135`		`- # Bug report: https://github.com/arduino/ArduinoCore-mbed/issues/48`
`136`		`- # Change the value to true once it is fixed.`
`137`		`- pulsein: false`
	`135`	`+ pulsein: true`
`138`	`136`	`- fqbn: arduino:sam:arduino_due_x`
`139`	`137`	`usb: true`
`140`	`138`	`serial1: true`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 9b2ba95

File tree

1 file changed

1 file changed

`‎.github/workflows/compile-examples.yml‎`

0 commit comments