Commit f830a43

authored

Merge pull request #48 from arduino/per1234/dot_a_linkage-schema-checks

Add schema provided checks for library.properties dot_a_linkage field

2 parents 5f0c17c + f8ecb47 commit f830a43Copy full SHA for f830a43

File tree

+33

-0

lines changed

check
- checkconfigurations
  - checkconfigurations.go
- checkfunctions
  - library.go

+33

-0

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -656,6 +656,21 @@ var configurations = []Type{`
`656`	`656`	`ErrorModes: nil,`
`657`	`657`	`CheckFunction: checkfunctions.LibraryPropertiesDependsFieldNotInIndex,`
`658`	`658`	`},`
	`659`	`+ {`
	`660`	`+ ProjectType: projecttype.Library,`
	`661`	`+ Category: "library.properties",`
	`662`	`+ Subcategory: "dot_a_linkage field",`
	`663`	`+ ID: "",`
	`664`	`+ Brief: "invalid value",`
	`665`	`+ Description: "",`
	`666`	`+ MessageTemplate: "invalid dot_a_linkage field value {{.}} in library.properties. See https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format",`
	`667`	`+ DisableModes: nil,`
	`668`	`+ EnableModes: []checkmode.Type{checkmode.All},`
	`669`	`+ InfoModes: nil,`
	`670`	`+ WarningModes: []checkmode.Type{checkmode.Permissive},`
	`671`	`+ ErrorModes: []checkmode.Type{checkmode.Default},`
	`672`	`+ CheckFunction: checkfunctions.LibraryPropertiesDotALinkageFieldInvalid,`
	`673`	`+ },`
`659`	`674`	`{`
`660`	`675`	`ProjectType: projecttype.Sketch,`
`661`	`676`	`Category: "structure",`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -670,6 +670,24 @@ func LibraryPropertiesDependsFieldNotInIndex() (result checkresult.Type, output`
`670`	`670`	`return checkresult.Pass, ""`
`671`	`671`	`}`
`672`	`672`
	`673`	`+// LibraryPropertiesDotALinkageFieldInvalid checks for invalid value in the library.properties "dot_a_linkage" field.`
	`674`	`+func LibraryPropertiesDotALinkageFieldInvalid() (result checkresult.Type, output string) {`
	`675`	`+ if checkdata.LibraryPropertiesLoadError() != nil {`
	`676`	`+ return checkresult.NotRun, ""`
	`677`	`+ }`
	`678`	`+`
	`679`	`+ dotALinkage, ok := checkdata.LibraryProperties().GetOk("dot_a_linkage")`
	`680`	`+ if !ok {`
	`681`	`+ return checkresult.NotRun, ""`
	`682`	`+ }`
	`683`	`+`
	`684`	`+ if schema.PropertyEnumMismatch("dot_a_linkage", checkdata.LibraryPropertiesSchemaValidationResult()[compliancelevel.Specification], configuration.SchemasPath()) {`
	`685`	`+ return checkresult.Fail, dotALinkage`
	`686`	`+ }`
	`687`	`+`
	`688`	`+ return checkresult.Pass, ""`
	`689`	`+}`
	`690`	`+`
`673`	`691`	`// spellCheckLibraryPropertiesFieldValue returns the value of the provided library.properties field with commonly misspelled words corrected.`
`674`	`692`	`func spellCheckLibraryPropertiesFieldValue(fieldName string) (result checkresult.Type, output string) {`
`675`	`693`	`if checkdata.LibraryPropertiesLoadError() != nil {`

Comments

(0)