Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit e8043e1

Browse files
committed
Correct order of arguments in test equality assertions
The order of the arguments is expected, actual. I had it backwards, resulting in very confusing test failure messages.
1 parent 80c12cb commit e8043e1

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

‎internal/project/projectdata/packageindex_test.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -159,32 +159,32 @@ func TestInitializeForPackageIndex(t *testing.T) {
159159
testTable.packageIndexPackagesAssertion(t, PackageIndexPackages(), testTable.testName)
160160
if PackageIndexPackages() != nil {
161161
for index, packageIndexPackage := range PackageIndexPackages() {
162-
assert.Equal(t, packageIndexPackage.ID, testTable.packageIndexPackagesDataAssertion[index].ID, testTable.testName)
163-
assert.Equal(t, packageIndexPackage.JSONPointer, testTable.packageIndexPackagesDataAssertion[index].JSONPointer, testTable.testName)
162+
assert.Equal(t, testTable.packageIndexPackagesDataAssertion[index].ID, packageIndexPackage.ID, testTable.testName)
163+
assert.Equal(t, testTable.packageIndexPackagesDataAssertion[index].JSONPointer, packageIndexPackage.JSONPointer, testTable.testName)
164164
}
165165
}
166166

167167
testTable.packageIndexPlatformsAssertion(t, PackageIndexPlatforms(), testTable.testName)
168168
if PackageIndexPlatforms() != nil {
169169
for index, packageIndexPlatform := range PackageIndexPlatforms() {
170-
assert.Equal(t, packageIndexPlatform.ID, testTable.packageIndexPlatformsDataAssertion[index].ID, testTable.testName)
171-
assert.Equal(t, packageIndexPlatform.JSONPointer, testTable.packageIndexPlatformsDataAssertion[index].JSONPointer, testTable.testName)
170+
assert.Equal(t, testTable.packageIndexPlatformsDataAssertion[index].ID, packageIndexPlatform.ID, testTable.testName)
171+
assert.Equal(t, testTable.packageIndexPlatformsDataAssertion[index].JSONPointer, packageIndexPlatform.JSONPointer, testTable.testName)
172172
}
173173
}
174174

175175
testTable.packageIndexToolsAssertion(t, PackageIndexTools(), testTable.testName)
176176
if PackageIndexTools() != nil {
177177
for index, packageIndexTool := range PackageIndexTools() {
178-
assert.Equal(t, packageIndexTool.ID, testTable.packageIndexToolsDataAssertion[index].ID, testTable.testName)
179-
assert.Equal(t, packageIndexTool.JSONPointer, testTable.packageIndexToolsDataAssertion[index].JSONPointer, testTable.testName)
178+
assert.Equal(t, testTable.packageIndexToolsDataAssertion[index].ID, packageIndexTool.ID, testTable.testName)
179+
assert.Equal(t, testTable.packageIndexToolsDataAssertion[index].JSONPointer, packageIndexTool.JSONPointer, testTable.testName)
180180
}
181181
}
182182

183183
testTable.packageIndexSystemsAssertion(t, PackageIndexSystems(), testTable.testName)
184184
if PackageIndexSystems() != nil {
185185
for index, packageIndexSystem := range PackageIndexSystems() {
186-
assert.Equal(t, packageIndexSystem.ID, testTable.packageIndexSystemsDataAssertion[index].ID, testTable.testName)
187-
assert.Equal(t, packageIndexSystem.JSONPointer, testTable.packageIndexSystemsDataAssertion[index].JSONPointer, testTable.testName)
186+
assert.Equal(t, testTable.packageIndexSystemsDataAssertion[index].ID, packageIndexSystem.ID, testTable.testName)
187+
assert.Equal(t, testTable.packageIndexSystemsDataAssertion[index].JSONPointer, packageIndexSystem.JSONPointer, testTable.testName)
188188
}
189189
}
190190
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /