Commit cbb9d19

authored

Always set the versioned runtime.tool property for all installed tools (#1106)

For example if we have bossac 1.7.1 and 1.9.0 installed, this will result in the following properties available during upload: {runtime.tools.bossac-1.7.0-arduino3.path} => /path/to/bossac/1.7.0 {runtime.tools.bossac-1.9.0-arduino3.path} => /path/to/bossac/1.9.0 {runtime.tools.bossac.path} => /path/to/bossac/1.9.0 some platforms fails to correctly specify the version of the tool in the package_index.json but they do the correct specification in the recipes. This patch allows to not fail in this latter case.

1 parent e20cbc1 commit cbb9d19Copy full SHA for cbb9d19

File tree

1 file changed

-0

lines changed

commands/upload
- upload.go

1 file changed

-0

lines changed

`‎commands/upload/upload.go‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,9 @@ func runProgramAction(pm *packagemanager.PackageManager,`
`213`	`213`	`uploadProperties.Merge(programmer.Properties)`
`214`	`214`	`}`
`215`	`215`
	`216`	`+ for _, tool := range pm.GetAllInstalledToolsReleases() {`
	`217`	`+ uploadProperties.Merge(tool.RuntimeProperties())`
	`218`	`+ }`
`216`	`219`	`if requiredTools, err := pm.FindToolsRequiredForBoard(board); err == nil {`
`217`	`220`	`for _, requiredTool := range requiredTools {`
`218`	`221`	`logrus.WithField("tool", requiredTool).Info("Tool required for upload")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit cbb9d19

File tree

1 file changed

1 file changed

`‎commands/upload/upload.go‎`

0 commit comments