Commit ca4a4ec

authored

In compile command try to release the package manager lock ASAP (#2741)

* In `compile` command try to release the package manager lock ASAP * Applied suggestion from code review

1 parent c3d05d6 commit ca4a4ecCopy full SHA for ca4a4ec

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ import (`
`22`	`22`	`"io"`
`23`	`23`	`"sort"`
`24`	`24`	`"strings"`
	`25`	`+ "sync"`
`25`	`26`	`"time"`
`26`	`27`
`27`	`28`	`"github.com/arduino/arduino-cli/commands/cmderrors"`
`@@ -81,6 +82,7 @@ func (s arduinoCoreServerImpl) Compile(req rpc.CompileRequest, stream rpc.Ardu`
`81`	`82`	`if err != nil {`
`82`	`83`	`return err`
`83`	`84`	`}`
	`85`	`+ release = sync.OnceFunc(release)`
`84`	`86`	`defer release()`
`85`	`87`
`86`	`88`	`if pme.Dirty() {`
`@@ -358,6 +360,10 @@ func (s arduinoCoreServerImpl) Compile(req rpc.CompileRequest, stream rpc.Ardu`
`358`	`360`	`targetBoard.String(), "'build.board'", sketchBuilder.GetBuildProperties().Get("build.board")) + "\n"))`
`359`	`361`	`}`
`360`	`362`
	`363`	`+ // Release package manager`
	`364`	`+ release()`
	`365`	`+`
	`366`	`+ // Perform the actual build`
`361`	`367`	`if err := sketchBuilder.Build(); err != nil {`
`362`	`368`	`return &cmderrors.CompileFailedError{Message: err.Error()}`
`363`	`369`	`}`

Comments

(0)