Commit ba04e61

ardnewcmaglie

and

committed

Apply suggestions from code review

Co-authored-by: Cristian Maglie <c.maglie@bug.st>

1 parent d67f3d7 commit ba04e61Copy full SHA for ba04e61

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,12 +53,13 @@ func runGetCommand(cmd *cobra.Command, args []string) {`
`53`	`53`	`for _, toGet := range args {`
`54`	`54`	`resp, err := svc.SettingsGetValue(cmd.Context(), &rpc.SettingsGetValueRequest{Key: toGet})`
`55`	`55`	`if err != nil {`
`56`		`- feedback.Fatal(tr("Cannot get the key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)`
	`56`	`+ feedback.Fatal(tr("Cannot get the configuration key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)`
`57`	`57`	`}`
`58`	`58`	`var result getResult`
`59`	`59`	`err = json.Unmarshal([]byte(resp.GetJsonData()), &result.resp)`
`60`	`60`	`if err != nil {`
`61`		`- feedback.Fatal(tr("Cannot parse JSON for key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)`
	`61`	`+ // Should never happen...`
	`62`	`+ panic(fmt.Sprintf("Cannot parse JSON for key %[1]s: %[2]v", toGet, err))`
`62`	`63`	`}`
`63`	`64`	`feedback.PrintResult(result)`
`64`	`65`	`}`

Comments

(0)