Commit 92aad00

cmagliealessio-perugini

and

committed

Apply suggestions from code review

Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>

1 parent 825e91d commit 92aad00Copy full SHA for 92aad00

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ var runProcess = func(args ...string) []string {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`// DetectCompilerFromCommandLine tries to detect a compiler from a given command line.`
`47`		`-// If probleCompiler is true, the compiler may be executed with different flags to`
	`47`	`+// If probeCompiler is true, the compiler may be executed with different flags to`
`48`	`48`	`// infer the version or capabilities.`
`49`	`49`	`func DetectCompilerFromCommandLine(args []string, probeCompiler bool) *DetectedCompiler {`
`50`	`50`	`if len(args) == 0 {`
`@@ -61,7 +61,7 @@ func DetectCompilerFromCommandLine(args []string, probeCompiler bool) *DetectedC`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`if family == "gcc" && probeCompiler {`
`64`		`- // Run "gcc --verion" to obtain more info`
	`64`	`+ // Run "gcc --version" to obtain more info`
`65`	`65`	`res.DetailedVersion = runProcess(args[0], "--version")`
`66`	`66`
`67`	`67`	`// Usually on the first line we get the compiler architecture and`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,5 @@ func runParserTest(t *testing.T, testFile string) {`
`52`	`52`	`require.NoError(t, err)`
`53`	`53`	`golden, err := paths.New("testdata", "compiler_outputs", testFile+".json").ReadFile()`
`54`	`54`	`require.NoError(t, err)`
`55`		`- // fmt.Println(string(output))`
`56`	`55`	`require.Equal(t, string(golden), string(output))`
`57`	`56`	`}`

Comments

(0)