Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 8b6adfb

Browse files
Removing deprecated 'update' functions (#88)
1 parent 804daa3 commit 8b6adfb

File tree

5 files changed

+4
-24
lines changed

5 files changed

+4
-24
lines changed

‎src/ArduinoIoTCloud.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ class ArduinoIoTCloudClass {
7575
virtual bool disconnect() = 0;
7676

7777
virtual void update() = 0;
78-
virtual void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) = 0;
79-
virtual void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated)) = 0; /* Attention: Function is deprecated - use 'addCallback(ArduinoIoTCloudConnectionEvent::SYNC, &onSync)' for adding a onSyncCallback instead */
8078

8179
virtual int connected() = 0;
8280

‎src/ArduinoIoTCloudLPWAN.cpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ int ArduinoIoTCloudLPWAN::begin(LPWANConnectionHandler& connection, bool retry)
5656
return 1;
5757
}
5858

59-
void ArduinoIoTCloudLPWAN::update(CallbackFunc onSyncCompleteCallback) {
59+
void ArduinoIoTCloudLPWAN::update() {
6060
// Check if a primitive property wrapper is locally changed
6161
Thing.updateTimestampOnLocallyChangedProperties();
6262

@@ -82,9 +82,6 @@ void ArduinoIoTCloudLPWAN::update(CallbackFunc onSyncCompleteCallback) {
8282
sendPropertiesToCloud();
8383

8484

85-
if (onSyncCompleteCallback != NULL) {
86-
(*onSyncCompleteCallback)();
87-
}
8885
execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);
8986

9087
}

‎src/ArduinoIoTCloudLPWAN.h‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,7 @@ class ArduinoIoTCloudLPWAN : public ArduinoIoTCloudClass {
3030
int connect();
3131
bool disconnect();
3232
int connected();
33-
inline void update() {
34-
update(NULL);
35-
}
36-
inline void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) {
37-
update(NULL);
38-
}
39-
void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated));
33+
void update();
4034
void connectionCheck();
4135
void printDebugInfo();
4236
int begin(LPWANConnectionHandler& connection, bool retry = false);

‎src/ArduinoIoTCloudTCP.cpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ bool ArduinoIoTCloudTCP::disconnect() {
219219
return true;
220220
}
221221

222-
void ArduinoIoTCloudTCP::update(CallbackFunc onSyncCompleteCallback) {
222+
void ArduinoIoTCloudTCP::update() {
223223
// Check if a primitive property wrapper is locally changed
224224
Thing.updateTimestampOnLocallyChangedProperties();
225225

@@ -245,9 +245,6 @@ void ArduinoIoTCloudTCP::update(CallbackFunc onSyncCompleteCallback) {
245245
}
246246
break;
247247
case ArduinoIoTSynchronizationStatus::SYNC_STATUS_VALUES_PROCESSED: {
248-
if (onSyncCompleteCallback != NULL) {
249-
(*onSyncCompleteCallback)();
250-
}
251248
execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);
252249
_syncStatus = ArduinoIoTSynchronizationStatus::SYNC_STATUS_SYNCHRONIZED;
253250
}

‎src/ArduinoIoTCloudTCP.h‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,7 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass {
5353
int connect();
5454
bool disconnect();
5555
int connected();
56-
inline void update() {
57-
update(NULL);
58-
}
59-
inline void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) {
60-
update(NULL);
61-
}
62-
void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated));
56+
void update();
6357
void connectionCheck();
6458
void printDebugInfo();
6559
#ifdef BOARD_HAS_ECCX08

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /