Commit 8759bf4

authored

GH-612: core search can match Platform#ID too. (#615)

When matching against a Platform#ID, the match must be a case-insensitive exact match. Closes #612. Signed-off-by: Akos Kitta <kittaakos@typefox.io>

1 parent fbcd87f commit 8759bf4Copy full SHA for 8759bf4

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,10 @@ func match(line, searchArgs string) bool {`
`29`	`29`	`return strings.Contains(strings.ToLower(line), strings.ToLower(searchArgs))`
`30`	`30`	`}`
`31`	`31`
	`32`	`+func exactMatch(line, searchArgs string) bool {`
	`33`	`+ return strings.Compare(strings.ToLower(line), strings.ToLower(searchArgs)) == 0`
	`34`	`+}`
	`35`	`+`
`32`	`36`	`// PlatformSearch FIXMEDOC`
`33`	`37`	`func PlatformSearch(instanceID int32, searchArgs string, allVersions bool) (*rpc.PlatformSearchResp, error) {`
`34`	`38`	`pm := commands.GetPackageManager(instanceID)`
`@@ -55,7 +59,7 @@ func PlatformSearch(instanceID int32, searchArgs string, allVersions bool) (*rpc`
`55`	`59`	`}`
`56`	`60`
`57`	`61`	`// platform has a valid release, check if it matches the search arguments`
`58`		`- if match(platform.Name, searchArgs) \|\| match(platform.Architecture, searchArgs) {`
	`62`	`+ if match(platform.Name, searchArgs) \|\| match(platform.Architecture, searchArgs) \|\|exactMatch(platform.String(), searchArgs) {`
`59`	`63`	`if allVersions {`
`60`	`64`	`res = append(res, platform.GetAllReleases()...)`
`61`	`65`	`} else {`

Comments

(0)