Commit 7f64261

committed

Resource: increase code coverage

1 parent d552883 commit 7f64261Copy full SHA for 7f64261

File tree

+28

-5

lines changed

+28

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,11 @@ func (r DownloadResource) IsCached(downloadDir paths.Path) (bool, error) {`
`52`	`52`
`53`	`53`	`// Download a DownloadResource.`
`54`	`54`	`func (r DownloadResource) Download(downloadDir paths.Path, config downloader.Config) (downloader.Downloader, error) {`
	`55`	`+ path, err := r.ArchivePath(downloadDir)`
	`56`	`+ if err != nil {`
	`57`	`+ return nil, fmt.Errorf("getting archive path: %s", err)`
	`58`	`+ }`
	`59`	`+`
`55`	`60`	`cached, err := r.TestLocalArchiveIntegrity(downloadDir)`
`56`	`61`	`if err != nil {`
`57`	`62`	`return nil, fmt.Errorf("testing local archive integrity: %s", err)`
`@@ -61,11 +66,6 @@ func (r DownloadResource) Download(downloadDir paths.Path, config *downloader.`
`61`	`66`	`return nil, nil`
`62`	`67`	`}`
`63`	`68`
`64`		`- path, err := r.ArchivePath(downloadDir)`
`65`		`- if err != nil {`
`66`		`- return nil, fmt.Errorf("getting archive path: %s", err)`
`67`		`- }`
`68`		`-`
`69`	`69`	`if stats, err := path.Stat(); os.IsNotExist(err) {`
`70`	`70`	`// normal download`
`71`	`71`	`} else if err == nil && stats.Size() > r.Size {`

Lines changed: 23 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,29 @@ func TestResourcesSanityChecks(t *testing.T) {`
`84`	`84`	`}`
`85`	`85`	`}`
`86`	`86`
	`87`	`+func TestResourceErrorHandling(t *testing.T) {`
	`88`	`+ tmp, err := paths.MkTempDir("", "")`
	`89`	`+ require.NoError(t, err)`
	`90`	`+ defer tmp.RemoveAll()`
	`91`	`+`
	`92`	`+ r := &DownloadResource{`
	`93`	`+ ArchiveFileName: "..",`
	`94`	`+ CachePath: "cache",`
	`95`	`+ }`
	`96`	`+`
	`97`	`+ c, err := r.IsCached(tmp)`
	`98`	`+ require.Error(t, err)`
	`99`	`+ require.False(t, c)`
	`100`	`+`
	`101`	`+ d, err := r.Download(tmp, nil)`
	`102`	`+ require.Error(t, err)`
	`103`	`+ require.Nil(t, d)`
	`104`	`+`
	`105`	`+ e, err := r.TestLocalArchiveIntegrity(tmp)`
	`106`	`+ require.Error(t, err)`
	`107`	`+ require.False(t, e)`
	`108`	`+}`
	`109`	`+`
`87`	`110`	`func TestDownloadApplyUserAgentHeaderUsingConfig(t *testing.T) {`
`88`	`111`	`goldUserAgentValue := fmt.Sprintf("arduino-cli/0.0.0-test.preview (amd64; linux; go1.12.4) Commit:deadbeef/Build:2019年06月12日 11:11:11.111")`
`89`	`112`	`goldUserAgentString := "User-Agent: " + goldUserAgentValue`

Comments

(0)