Commit 719185d

committed

Fail if a sketch file is a broken symlink

1 parent f793bb1 commit 719185dCopy full SHA for 719185d

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,10 @@ func (s *Sketch) supportedFiles() (paths.PathList, error) {`
`176`	`176`
`177`	`177`	`files, err := s.FullPath.ReadDirRecursiveFiltered(`
`178`	`178`	`paths.AndFilter(`
`179`		`- filterOutBrokenLinks,`
	`179`	`+ paths.OrFilter(`
	`180`	`+ filterValidExtensions,`
	`181`	`+ filterOutBrokenLinks,`
	`182`	`+ ),`
`180`	`183`	`filterOutBuildPaths,`
`181`	`184`	`),`
`182`	`185`	`paths.AndFilter(`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,4 +37,11 @@ func TestCompileWithBrokenSymLinks(t *testing.T) {`
`37`	`37`	`_, _, err = cli.Run("compile", "-b", "arduino:avr:uno", sketch.String())`
`38`	`38`	`require.NoError(t, err)`
`39`	`39`	`})`
	`40`	`+`
	`41`	`+ t.Run("SketchFileBroken", func(t *testing.T) {`
	`42`	`+ sketch, err := paths.New("testdata", "ValidSketchWithBrokenSketchFileSymlink").Abs()`
	`43`	`+ require.NoError(t, err)`
	`44`	`+ _, _, err = cli.Run("compile", "-b", "arduino:avr:uno", sketch.String())`
	`45`	`+ require.Error(t, err)`
	`46`	`+ })`
`40`	`47`	`}`

Lines changed: 2 additions & 0 deletions

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+broken`

Comments

(0)