Commit 694560d

committed

add -b or --fqbn completion for the monitor command and tests

1 parent 042eb2f commit 694560dCopy full SHA for 694560d

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,9 @@ func NewCommand() *cobra.Command {`
`61`	`61`	`cmd.Flags().StringSliceVarP(&configs, "config", "c", []string{}, tr("Configuration of the port."))`
`62`	`62`	`cmd.Flags().BoolVarP(&quiet, "quiet", "q", false, tr("Run in silent mode, show only monitor input and output."))`
`63`	`63`	`cmd.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))`
	`64`	`+ cmd.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {`
	`65`	`+ return arguments.GetInstalledBoards(), cobra.ShellCompDirectiveDefault`
	`66`	`+ })`
`64`	`67`	`cmd.MarkFlagRequired("port")`
`65`	`68`	`return cmd`
`66`	`69`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,8 @@ def test_core_completion(run_command):`
`179`	`179`	`assert "arduino:avr:uno" in result.stdout`
`180`	`180`	`result = run_command(["__complete", "upload", "-b", ""])`
`181`	`181`	`assert "arduino:avr:uno" in result.stdout`
	`182`	`+ result = run_command(["__complete", "monitor", "-b", ""])`
	`183`	`+ assert "arduino:avr:uno" in result.stdout`
`182`	`184`	`result = run_command(["__complete", "burn-bootloader", "-l", ""])`
`183`	`185`	`assert "network" in result.stdout`
`184`	`186`	`result = run_command(["__complete", "compile", "-l", ""])`
`@@ -187,6 +189,8 @@ def test_core_completion(run_command):`
`187`	`189`	`assert "network" in result.stdout`
`188`	`190`	`result = run_command(["__complete", "upload", "-l", ""])`
`189`	`191`	`assert "network" in result.stdout`
	`192`	`+ result = run_command(["__complete", "monitor", "-l", ""])`
	`193`	`+ assert "network" in result.stdout`
`190`	`194`	`result = run_command(["__complete", "burn-bootloader", "-P", ""])`
`191`	`195`	`assert "atmel_ice" in result.stdout`
`192`	`196`	`result = run_command(["__complete", "compile", "-P", ""])`

Comments

(0)