Commit 6753a12

authored

[BREAKING]: gRPC drop query field from LibrarySearchRequest (#2388)

1 parent b7ce9c8 commit 6753a12Copy full SHA for 6753a12

File tree

+255

-270

lines changed

+255

-270

lines changed

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,10 +40,6 @@ func LibrarySearch(ctx context.Context, req rpc.LibrarySearchRequest) (rpc.Lib`
`40`	`40`	`func searchLibrary(req rpc.LibrarySearchRequest, lm librariesmanager.LibrariesManager) *rpc.LibrarySearchResponse {`
`41`	`41`	`res := []*rpc.SearchedLibrary{}`
`42`	`42`	`query := req.GetSearchArgs()`
`43`		`- if query == "" {`
`44`		`- query = req.GetQuery()`
`45`		`- }`
`46`		`-`
`47`	`43`	`matcher := MatcherFromQueryString(query)`
`48`	`44`
`49`	`45`	`for _, lib := range lm.Index.Libraries {`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,10 @@ Here you can find a list of migration guides to handle breaking changes between`
`4`	`4`
`5`	`5`	`## 0.36.0`
`6`	`6`
	`7`	+### gRPC `cc.arduino.cli.commands.v1.LibrarySearchRequest` message has been changed.
	`8`	`+`
	`9`	+The `query` field has been removed, use `search_args` instead.
	`10`	`+`
`7`	`11`	### CLI `core list` and `core search` changed JSON output.
`8`	`12`
`9`	`13`	`Below is an example of the response containing an object with all possible keys set.`

Comments

(0)