Commit 4f3fec6

howjmayMassimiliano Pippi

authored and

Massimiliano Pippi

committed

feat: Libraries (un)install name inconcistency (#443)

Fix the inconsistent name of libraries when installing and uninstalling.

1 parent f2df284 commit 4f3fec6Copy full SHA for 4f3fec6

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ import (`
`24`	`24`	`"github.com/arduino/arduino-cli/arduino/cores"`
`25`	`25`	`"github.com/arduino/arduino-cli/arduino/libraries"`
`26`	`26`	`"github.com/arduino/arduino-cli/arduino/libraries/librariesindex"`
	`27`	`+ "github.com/arduino/arduino-cli/arduino/utils"`
`27`	`28`	`paths "github.com/arduino/go-paths-helper"`
`28`	`29`	`"github.com/pmylund/sortutil"`
`29`	`30`	`"github.com/sirupsen/logrus"`
`@@ -209,7 +210,8 @@ func (sc LibrariesManager) LoadLibrariesFromDir(librariesDir LibrariesDir) err`
`209`	`210`	`// name and version or, if the version is nil, the library installed`
`210`	`211`	`// in the sketchbook.`
`211`	`212`	`func (sc LibrariesManager) FindByReference(libRef librariesindex.Reference) *libraries.Library {`
`212`		`- alternatives, have := sc.Libraries[libRef.Name]`
	`213`	`+ saneName := utils.SanitizeName(libRef.Name)`
	`214`	`+ alternatives, have := sc.Libraries[saneName]`
`213`	`215`	`if !have {`
`214`	`216`	`return nil`
`215`	`217`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ def run_command(pytestconfig, data_dir, downloads_dir, working_dir):`
`56`	`56`	`Useful reference:`
`57`	`57`	`http://docs.pyinvoke.org/en/1.2/api/runners.html#invoke.runners.Result`
`58`	`58`	`"""`
`59`		`- cli_path = os.path.join(pytestconfig.rootdir, "..", "arduino-cli")`
	`59`	`+ cli_path = os.path.join(str(pytestconfig.rootdir), "..", "arduino-cli")`
`60`	`60`	`env = {`
`61`	`61`	`"ARDUINO_DATA_DIR": data_dir,`
`62`	`62`	`"ARDUINO_DOWNLOADS_DIR": downloads_dir,`

Comments

(0)