Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 32d8833

Browse files
[skip-changelog] bump golangci-lint to v1.57.x (#2571)
1 parent 6faca0f commit 32d8833

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

‎.github/workflows/check-go-task.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
- name: golangci-lint
117117
uses: golangci/golangci-lint-action@v4
118118
with:
119-
version: v1.55
119+
version: v1.57
120120

121121
- name: Check style
122122
env:

‎.golangci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ linters-settings:
8181

8282
issues:
8383
# Fix found issues (if it's supported by the linter).
84-
fix: true
84+
fix: false
8585
# List of regexps of issue texts to exclude.
8686
#
8787
# But independently of this option we use default exclude patterns,

‎commands/instances.go‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB rp
480480
downloadCB.Start(u, tr("Downloading index: %s", u))
481481
downloadCB.End(false, msg)
482482
failed = true
483-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
483+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
484484
continue
485485
}
486486

@@ -498,9 +498,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB rp
498498
downloadCB.Start(u, tr("Downloading index: %s", filepath.Base(URL.Path)))
499499
downloadCB.End(false, msg)
500500
failed = true
501-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
501+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
502502
} else {
503-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_SKIPPED))
503+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_SKIPPED))
504504
}
505505
continue
506506
}
@@ -512,14 +512,14 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB rp
512512
downloadCB.Start(u, tr("Downloading index: %s", filepath.Base(URL.Path)))
513513
downloadCB.End(false, tr("Invalid index URL: %s", err))
514514
failed = true
515-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
515+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
516516
continue
517517
}
518518
indexFile := indexpath.Join(indexFileName)
519519
if info, err := indexFile.Stat(); err == nil {
520520
ageSecs := int64(time.Since(info.ModTime()).Seconds())
521521
if ageSecs < req.GetUpdateIfOlderThanSecs() {
522-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_ALREADY_UP_TO_DATE))
522+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_ALREADY_UP_TO_DATE))
523523
continue
524524
}
525525
}
@@ -530,9 +530,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB rp
530530
}
531531
if err := indexResource.Download(indexpath, downloadCB); err != nil {
532532
failed = true
533-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
533+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_FAILED))
534534
} else {
535-
result.UpdatedIndexes = append(result.UpdatedIndexes, report(URL, rpc.IndexUpdateReport_STATUS_UPDATED))
535+
result.UpdatedIndexes = append(result.GetUpdatedIndexes(), report(URL, rpc.IndexUpdateReport_STATUS_UPDATED))
536536
}
537537
}
538538

‎internal/cli/feedback/warn_deprecated.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ import (
2525
// WarnAboutDeprecatedFiles warns the user that a type of sketch files are deprecated
2626
func WarnAboutDeprecatedFiles(s *rpc.Sketch) {
2727
var files []string
28-
for _, f := range s.OtherSketchFiles {
28+
for _, f := range s.GetOtherSketchFiles() {
2929
if strings.HasSuffix(f, ".pde") {
3030
files = append(files, f)
3131
}
3232
}
33-
if strings.HasSuffix(s.MainFile, ".pde") {
34-
files = append(files, s.MainFile)
33+
if strings.HasSuffix(s.GetMainFile(), ".pde") {
34+
files = append(files, s.GetMainFile())
3535
}
3636
if len(files) > 0 {
3737
// .pde files are still supported but deprecated, this warning urges the user to rename them

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /