Commit 0167c2d

cmaglieper1234

and

authored

Apply suggestions from code review

Co-authored-by: per1234 <accounts@perglass.com>

1 parent 82e47d3 commit 0167c2dCopy full SHA for 0167c2d

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ tasks:`
`90`	`90`
`91`	`91`	`# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/test-go-task/Taskfile.yml`
`92`	`92`	`go:test:`
`93`		`- desc: Run unit tests and part of the integration tests`
	`93`	`+ desc: Run unit tests and the Go-based integration tests`
`94`	`94`	`deps:`
`95`	`95`	`- task: go:build`
`96`	`96`	`dir: '{{default "./" .GO_MODULE_PATH}}'`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ func TestCoreSearch(t *testing.T) {`
`62`	`62`	`out, _, err = cli.Run("core", "search", "test_core", "--all", "--format", "json", "--additional-urls="+url.String())`
`63`	`63`	`require.NoError(t, err)`
`64`	`64`	`requirejson.Len(t, out, 2)`
`65`		`- // requirejson.Len(t, out, 3) // Test failure`
`66`	`65`
`67`	`66`	`checkPlatformIsInJSONOutput := func(stdout []byte, id, version string) {`
`68`	`67`	jqquery := fmt.Sprintf(`[{id:"%s", latest:"%s"}]`, id, version)
`@@ -74,7 +73,6 @@ func TestCoreSearch(t *testing.T) {`
`74`	`73`	`require.NoError(t, err)`
`75`	`74`	`checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.5")`
`76`	`75`	`checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.6")`
`77`		`- //checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.9") // Test failure`
`78`	`76`
`79`	`77`	`// Search using Retrokit Package Maintainer`
`80`	`78`	`out, _, err = cli.Run("core", "search", "Retrokits-RK002", "--all", "--additional-urls="+url.String(), "--format", "json")`

Comments

(0)