Commit acfd904

committed

Removed KeysOfMapOfString* method

1 parent 5fd49b6 commit acfd904Copy full SHA for acfd904

File tree

-21

lines changed

-21

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,18 +30,18 @@`
`30`	`30`	`package builder`
`31`	`31`
`32`	`32`	`import (`
`33`		`- "github.com/arduino/arduino-builder/types"`
`34`		`- "github.com/arduino/arduino-builder/utils"`
`35`	`33`	`"fmt"`
`36`	`34`	`"sort"`
	`35`	`+`
	`36`	`+ "github.com/arduino/arduino-builder/types"`
`37`	`37`	`)`
`38`	`38`
`39`	`39`	`type DumpBuildProperties struct{}`
`40`	`40`
`41`	`41`	`func (s DumpBuildProperties) Run(ctx types.Context) error {`
`42`	`42`	`buildProperties := ctx.BuildProperties`
`43`	`43`
`44`		`- keys := utils.KeysOfMapOfString(buildProperties)`
	`44`	`+ keys := buildProperties.Keys()`
`45`	`45`	`sort.Strings(keys)`
`46`	`46`
`47`	`47`	`for _, key := range keys {`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ import (`
`39`	`39`	`"github.com/arduino/arduino-builder/constants"`
`40`	`40`	`"github.com/arduino/arduino-builder/i18n"`
`41`	`41`	`"github.com/arduino/arduino-builder/types"`
`42`		`- "github.com/arduino/arduino-builder/utils"`
`43`	`42`	`"github.com/arduino/go-properties-map"`
`44`	`43`	`)`
`45`	`44`
`@@ -63,7 +62,7 @@ func (s PlatformKeysRewriteLoader) Run(ctx types.Context) error {`
`63`	`62`	`if err != nil {`
`64`	`63`	`return i18n.WrapError(err)`
`65`	`64`	`}`
`66`		`- keys := utils.KeysOfMapOfString(txt)`
	`65`	`+ keys := txt.Keys()`
`67`	`66`	`sort.Strings(keys)`
`68`	`67`
`69`	`68`	`for _, key := range keys {`

Lines changed: 0 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,22 +52,6 @@ import (`
`52`	`52`	`"golang.org/x/text/unicode/norm"`
`53`	`53`	`)`
`54`	`54`
`55`		`-func KeysOfMapOfStringInterface(input map[string]interface{}) []string {`
`56`		`- var keys []string`
`57`		`- for key, _ := range input {`
`58`		`- keys = append(keys, key)`
`59`		`- }`
`60`		`- return keys`
`61`		`-}`
`62`		`-`
`63`		`-func KeysOfMapOfString(input map[string]string) []string {`
`64`		`- var keys []string`
`65`		`- for key, _ := range input {`
`66`		`- keys = append(keys, key)`
`67`		`- }`
`68`		`- return keys`
`69`		`-}`
`70`		`-`
`71`	`55`	`func PrettyOSName() string {`
`72`	`56`	`switch osName := runtime.GOOS; osName {`
`73`	`57`	`case "darwin":`

Comments

(0)