Commit c2b5eda

authored

feat: add brick details completions (#54)

This add completions from brick details while tabbing in cli mode.

1 parent 5a33829 commit c2b5edaCopy full SHA for c2b5eda

File tree

+24

-0

lines changed

+24

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ import (`
`22`	`22`
`23`	`23`	`"github.com/spf13/cobra"`
`24`	`24`
	`25`	`+ "github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/completion"`
`25`	`26`	`"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"`
`26`	`27`	`"github.com/arduino/arduino-app-cli/cmd/feedback"`
`27`	`28`	`"github.com/arduino/arduino-app-cli/internal/orchestrator/bricks"`
`@@ -36,6 +37,7 @@ func newBricksDetailsCmd(cfg config.Configuration) *cobra.Command {`
`36`	`37`	`Run: func(cmd *cobra.Command, args []string) {`
`37`	`38`	`bricksDetailsHandler(args[0], cfg)`
`38`	`39`	`},`
	`40`	`+ ValidArgsFunction: completion.BrickIDs(),`
`39`	`41`	`}`
`40`	`42`	`}`
`41`	`43`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ import (`
`24`	`24`	`"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"`
`25`	`25`	`"github.com/arduino/arduino-app-cli/cmd/feedback"`
`26`	`26`	`"github.com/arduino/arduino-app-cli/internal/orchestrator"`
	`27`	`+ "github.com/arduino/arduino-app-cli/internal/orchestrator/bricks"`
`27`	`28`	`"github.com/arduino/arduino-app-cli/internal/orchestrator/config"`
`28`	`29`	`)`
`29`	`30`
`@@ -97,3 +98,24 @@ func ApplicationNamesWithFilterFunc(cfg config.Configuration, filter func(apps o`
`97`	`98`	`return res, cobra.ShellCompDirectiveNoFileComp`
`98`	`99`	`}`
`99`	`100`	`}`
	`101`	`+`
	`102`	`+func BrickIDs() cobra.CompletionFunc {`
	`103`	`+ return BrickIDsWithFilterFunc(func(_ bricks.BrickListItem) bool { return true })`
	`104`	`+}`
	`105`	`+`
	`106`	`+func BrickIDsWithFilterFunc(filter func(apps bricks.BrickListItem) bool) cobra.CompletionFunc {`
	`107`	`+ return func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {`
	`108`	`+ brickList, err := servicelocator.GetBrickService().List()`
	`109`	`+ if err != nil {`
	`110`	`+ return nil, cobra.ShellCompDirectiveError`
	`111`	`+ }`
	`112`	`+`
	`113`	`+ var res []string`
	`114`	`+ for _, brick := range brickList.Bricks {`
	`115`	`+ if filter(brick) {`
	`116`	`+ res = append(res, brick.ID)`
	`117`	`+ }`
	`118`	`+ }`
	`119`	`+ return res, cobra.ShellCompDirectiveNoFileComp`
	`120`	`+ }`
	`121`	`+}`

Comments

(0)