Commit a5b8e43

committed

Fix format specifier for printing CAN message ID in CanMsg.h.

Regarding the X format specifier: C standard §7.21.6.1: "The unsigned int argument is converted to ..." On some platforms (e.g. mbed_nano), uint32_t, which is what's being printed here, is an unsigned long int, so this code causes a compiler warning. The fix is to use the format specifiers from §7.8.1, specifically PRIX32.

1 parent 50a27fb commit a5b8e43Copy full SHA for a5b8e43

File tree

1 file changed

-2

lines changed

api
- CanMsg.h

1 file changed

-2

lines changed

`‎api/CanMsg.h‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* INCLUDE`
`13`	`13`	`**************************************************************************************/`
`14`	`14`
`15`		`-#include <stdint.h>`
	`15`	`+#include <inttypes.h>`
`16`	`16`	`#include <string.h>`
`17`	`17`
`18`	`18`	`#include <Arduino.h>`
`@@ -68,7 +68,7 @@ class CanMsg : public Printable`
`68`	`68`	`size_t len = 0;`
`69`	`69`
`70`	`70`	`/* Print the header. */`
`71`		`- len = snprintf(buf, sizeof(buf), "[%08X] (%d) : ", id, data_length);`
	`71`	`+ len = snprintf(buf, sizeof(buf), "[%08" PRIX32 "] (%d) : ", id, data_length);`
`72`	`72`	`size_t n = p.write(buf, len);`
`73`	`73`
`74`	`74`	`/* Print the data. */`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit a5b8e43

File tree

1 file changed

1 file changed

`‎api/CanMsg.h‎`

0 commit comments